Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forcefully set configuration for InvenioRDM #36

Closed
fenekku opened this issue Dec 9, 2019 · 0 comments · Fixed by #37
Closed

Forcefully set configuration for InvenioRDM #36

fenekku opened this issue Dec 9, 2019 · 0 comments · Fixed by #37
Assignees
@fenekku
Projects
InvenioRDM December Board

Comments

@fenekku
Copy link
Contributor

fenekku commented Dec 9, 2019 •
edited
Loading

The invenio-app-rdm module should ensure that InvenioRDM specific configurations are set.

This is a non-trivial issue because:

  • there is no guaranteed configuration loading order among invenio modules.
  • invenio-rdm-records defines an InvenioRDM record in part via configuration, but it may be loaded after or before the configuration it is meant to change thus not working.
  • invenio-rdm-records used to forcefully set its configuration which would suffer from same problem but with invenio-app-rdm (this is fixed in config: use ext and only set defaults invenio-rdm-records#39)

The simple solution is: #37
We could write an ext.py and re-implement flask/config.py::from_object, but I don't see any real benefit.
@fenekku fenekku self-assigned this Dec 9, 2019
@fenekku fenekku added this to To do in InvenioRDM December Board via automation Dec 9, 2019
@fenekku fenekku moved this from To do to In progress in InvenioRDM December Board Dec 9, 2019
fenekku added a commit to fenekku/invenio-app-rdm that referenced this issue Dec 9, 2019
@fenekku
config: set external configuration via config.py
4087249 
- This approach has the advantange of being very simple
  and non-coupling. But it is new.
- Using ext.py could achieve the same thing, but it's more code
- closes inveniosoftware#36
@fenekku fenekku mentioned this issue Dec 9, 2019
Merged
@fenekku fenekku moved this from In progress to In Review in InvenioRDM December Board Dec 9, 2019
fenekku added a commit to fenekku/invenio-app-rdm that referenced this issue Dec 9, 2019
@fenekku
config: set external configuration via config.py
232ed77 
- This approach has the advantange of being very simple
  and non-coupling. But it is new.
- Using ext.py could achieve the same thing, but it's more code
- closes inveniosoftware#36
fenekku added a commit to fenekku/invenio-app-rdm that referenced this issue Dec 9, 2019
@fenekku
config: set external configuration via config.py
e815343 
- This approach has the advantange of being very simple
  and non-coupling. But it is new.
- Using ext.py could achieve the same thing, but it's more code
- closes inveniosoftware#36
InvenioRDM December Board automation moved this from In Review to Done Dec 10, 2019
fenekku added a commit that referenced this issue Dec 10, 2019
@fenekku
config: set external configuration via config.py
427a195 
- This approach has the advantange of being very simple
  and non-coupling. But it is new.
- Using ext.py could achieve the same thing, but it's more code
- closes #36
fenekku added a commit to fenekku/invenio-app-rdm that referenced this issue Dec 10, 2019
@fenekku
config: set external configuration via config.py
603f857 
- This approach has the advantange of being very simple
  and non-coupling. But it is new.
- Using ext.py could achieve the same thing, but it's more code
- closes inveniosoftware#36
fenekku added a commit that referenced this issue Dec 10, 2019
@fenekku
config: set external configuration via config.py
f35ce03 
- This approach has the advantange of being very simple
  and non-coupling. But it is new.
- Using ext.py could achieve the same thing, but it's more code
- closes #36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fenekku fenekku

Labels
None yet
Projects
No open projects
InvenioRDM December Board
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config: set external configuration via config.py fenekku/invenio-app-rdm
1 participant
@fenekku