config: use ext and only set defaults

[fenekku]

Step in the right direction but may be is not enough yet. If it runs after invenio-records-rest config, that wouldn't do: I think we need to have invenio-app-rdm hard set the config from this module to close that loophole.

[ppanero]

It is not clear to me, now if we "setdefault" and invenio-records-rest has been already loaded, this config will no be added. This means we need an ext.py in app-rdm, and to move the config back there?

[fenekku]

Yup, like I said, on its own this is not enough (although I should not have said "may" in that first sentence, but rather "will" :) )

we need to have invenio-app-rdm hard set the config from this module to close that loophole

That's the approach that I think could work best. We have invenio-rdm-records define the configuration it needs in its own config.py and set_defaults it in its own ext.py. Then, invenio-app-rdm would set invenio-rdm-records' config.py in its (invenio-app-rdm) config.py (via config entrypoint). I think this is possible because invenio-rdm-records is just a dependency (if not we will use ext.py rather than config entrypoint in invenio-app-rdm). We split definition and setting for 2 reasons:

1- so we can still keep coupled things together and, in particular,
2- test invenio-rdm-records with the correct configuration.

What do you think about that?

[ppanero]

Along with inveniosoftware/invenio-app-rdm#37

🚀 !