landing page: highlight verified community in communities list #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anikachurilova
commented
Feb 19, 2024
anikachurilova
commented
- closes record landing page: add "verified" badge to the list of communities -> try some mockups zenodo/zenodo-rdm#717
anikachurilova
force-pushed
the
verified-icon-in-communities-list
branch
from
2d9adcc
to
34ff283
Compare
| @@ -126,6 +126,7 @@ export class CommunitiesManagement extends Component { | |||
| error={error} | |||
| loading={loading} | |||
| maxDisplayedCommunities={MAX_COMMUNITIES} | |||
| branded={record.parent?.communities?.default} | |||
There was a problem hiding this comment.
question 1: only one community can have the verified icon?
question 2: why is the default community the one considered branded?
There was a problem hiding this comment.
- For now, only 1 community can be verified per record. In future, we will probably add a field
verifiedto the record, so then we can have more. - Branded community is the one that displays on top of the record landing page (with themed communities it also changes the UI). It is controlled by
record.parent.communities.defaultfield. Users can change branding in the manage communities modal on the landing page
There was a problem hiding this comment.
About (1) - just as info, records already have a verified field but it's related to content moderation.
|
Reviewed with @yashlamba |
0einstein0
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.