search, my dashboard: highlight verified community #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anikachurilova
force-pushed
the
highlight-verified-community
branch
2 times, most recently
from
3f977b3
to
6863899
Compare
There was a problem hiding this comment.
LGTM, we (@yashlamba) just have one question about the definition of a branded community. It was asked in another PR
0einstein0
reviewed
Feb 21, 2024
...nio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/components/RecordsResultsListItem.js
Outdated
Show resolved
Hide resolved
anikachurilova
force-pushed
the
highlight-verified-community
branch
3 times, most recently
from
c034f4c
to
61f1f2b
Compare
|
The "part of" should not show the "Fancy community". |
anikachurilova
force-pushed
the
highlight-verified-community
branch
4 times, most recently
from
3cede6f
to
45bdade
Compare
zzacharo
reviewed
Feb 27, 2024
| @@ -117,6 +146,9 @@ class RecordsResultsListItem extends Component { | |||
|
|
|||
| <div className="flex justify-space-between align-items-end"> | |||
| <small> | |||
| <p> | |||
| <b>{printPartOf()}</b> | |||
There was a problem hiding this comment.
Suggested change
| <b>{printPartOf()}</b> | |
| <b>{<PartOfCommunities />}</b> |
| @@ -58,6 +59,34 @@ class RecordsResultsListItem extends Component { | |||
| const filters = currentQueryState && Object.fromEntries(currentQueryState.filters); | |||
| const allVersionsVisible = filters?.allversions; | |||
| const numOtherVersions = versions.index - 1; | |||
| const communitiesEntries = result.parent?.communities?.entries; | |||
|
|
|||
| const printPartOf = () => { | |||
There was a problem hiding this comment.
Suggested change
| const printPartOf = () => { | |
| const PartOfCommunities = () => { |
| <Label | ||
| as="a" | ||
| href={`/communities/${verifiedCommunity.id}`} | ||
| style={{ backgroundColor: verifiedCommunity?.theme?.style?.primaryColor }} |
There was a problem hiding this comment.
I think that should translate to a className rather that inline style if the community is verified
There was a problem hiding this comment.
We need to discuss. Created an issue for this #2596
| return displayCommunity; | ||
| }; | ||
|
|
||
| const verifiedCommunity = displayCommunity(communities); |
There was a problem hiding this comment.
Suggested change
| const verifiedCommunity = displayCommunity(communities); | |
| const verifiedCommunity = filterBrandedCommunity(communities); |
assuming from the code branded == verified at the moment.
| @@ -42,6 +43,32 @@ export const ComputerTabletUploadsItem = ({ | |||
| ); | |||
| const uniqueViews = _get(result, "stats.all_versions.unique_views", 0); | |||
| const uniqueDownloads = _get(result, "stats.all_versions.unique_downloads", 0); | |||
| const communitiesEntries = result.parent?.communities?.entries; | |||
| const printPartOf = () => { | |||
| @@ -42,6 +43,33 @@ export const MobileUploadsItem = ({ | |||
| ); | |||
| const uniqueViews = _get(result, "stats.all_versions.unique_views", 0); | |||
| const uniqueDownloads = _get(result, "stats.all_versions.unique_downloads", 0); | |||
| const communitiesEntries = result.parent?.communities?.entries; | |||
| const printPartOf = () => { | |||
anikachurilova
force-pushed
the
highlight-verified-community
branch
from
45bdade
to
c12d997
Compare
* Add "Part of" to the global search and user dashboard * closes zenodo/zenodo-rdm#716
anikachurilova
force-pushed
the
highlight-verified-community
branch
from
c12d997
to
45f3356
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General search:
My dashboard:
My dashboard mobile:
