tests: change Travis to use Docker #133
Conversation
ntarocco
force-pushed
the
travis-docker-compose
branch
18 times, most recently
from
f7a673e
to
c279edd
Compare
|
@ppanero I was thinking to use |
ntarocco
force-pushed
the
travis-docker-compose
branch
from
c279edd
to
aafb999
Compare
|
@lnielsen to use Postgres 12, we need to upgrade SQLAlchemy min version from 1.1 to 1.2.18 |
ntarocco
force-pushed
the
travis-docker-compose
branch
from
aafb999
to
1cfe3f5
Compare
There was a problem hiding this comment.
Okay, I made some comments and then I realized actually the problem was that docker-compose-cli was not easy to integrate. So most likely you can ignore my comments 😅 . Could we have a chat IRL so I fully understand the issues?
If there is no rush to integrate this I would like to try to integrate docker-services-cli and potentially fix the problems. Maybe is just a matter of improving the documentation (sorry about that).
Update: Made a PR with some required changes in the cli part inveniosoftware/docker-services-cli#10.
| before_script: | ||
| - "docker --version" | ||
| - "docker-compose --version" | ||
| - if [ -n "${DOCKER_SERVICE}" ]; then |
There was a problem hiding this comment.
This should not be needed: Which case triggers this if? I am not able to understand it.
|
|
||
| script: | ||
| - "./run-tests.sh" | ||
|
|
||
| after_script: | ||
| - docker-compose -f docker-services.yml down |
There was a problem hiding this comment.
Should not be needed either. Should use docker-services-cli down
| - EXTRAS=mysql REQUIREMENTS=lowest SQLALCHEMY_DATABASE_URI="mysql+pymysql://travis@localhost:3306/invenio" | ||
| - EXTRAS=postgresql REQUIREMENTS=lowest SQLALCHEMY_DATABASE_URI="postgresql+psycopg2://postgres@localhost:5432/invenio" POSTGRESQL_VERSION="9.6" | ||
| - EXTRAS=postgresql REQUIREMENTS=lowest SQLALCHEMY_DATABASE_URI="postgresql+psycopg2://postgres@localhost:5432/invenio" POSTGRESQL_VERSION="10" | ||
| - EXTRAS=mysql REQUIREMENTS=lowest DOCKER_SERVICE=mysql SQLALCHEMY_DATABASE_URI="mysql+pymysql://testuser:testpsw@localhost:3306/invenio" MYSQL_VERSION="5.7" |
There was a problem hiding this comment.
We should be able to avoid all the DOCKER_SERVICE and URIs.
| @@ -0,0 +1,28 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
This file should not be needed.
Ok from my side. |
|
closed in favor of: #134 |
No description provided.