Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: migrate to docker-services-cli + Postgres 12 #134

Merged
merged 3 commits into from Oct 2, 2020
Merged

tests: migrate to docker-services-cli + Postgres 12 #134

merged 3 commits into from Oct 2, 2020

Conversation

ppanero
Copy link
Member

@ppanero ppanero commented Sep 28, 2020

@ntarocco ntarocco mentioned this pull request Sep 28, 2020
Closed
@ntarocco
Copy link
Contributor

ntarocco commented Sep 28, 2020 •
edited

@topless for Postgres 12, you will need 'SQLAlchemy>=1.2.18',.
It would be great to have 1 commit with the docker-services-cli integration and 1 commit with the changes for Postgres 12 if possible.

@ntarocco ntarocco changed the title tests: migrate to docker-services-cli tests: migrate to docker-services-cli + Postgres 12 Sep 28, 2020
@topless topless self-assigned this Sep 28, 2020
@ppanero
Copy link
Member Author

ppanero commented Sep 28, 2020

@ntarocco @topless I've squashed my part in one commit

@topless topless force-pushed the docker-services branch 2 times, most recently from 9cc32b4 to a9b533e Compare September 30, 2020 12:46
@topless topless marked this pull request as ready for review September 30, 2020 13:40
@topless topless force-pushed the docker-services branch 2 times, most recently from 949923d to 67ca4ea Compare October 1, 2020 08:12
lnielsen
lnielsen approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@lnielsen lnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor thing about the docker-services-cli dependency.

setup.py
'pytest-cov>=1.8.0',
'pytest-pep8>=1.0.6',
'pytest>=3.8.0,<5.0.0',
'docker-services-cli>=0.2.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: you don't need this one, it should be installed by default from pytest-invenio.

@ntarocco ntarocco merged commit 7c1409a into inveniosoftware:master Oct 2, 2020
@ntarocco ntarocco mentioned this pull request Oct 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnielsen lnielsen lnielsen approved these changes

Assignees

@topless topless

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ppanero @ntarocco @lnielsen @topless