scheduler: Implement custom RunScheduler #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashlamba
force-pushed
the
scheduler
branch
2 times, most recently
from
ced82ec
to
19abf92
Compare
slint
approved these changes
May 24, 2024
invenio_jobs/services/scheduler.py
Outdated
| """Initialize the database scheduler.""" | ||
| Scheduler.__init__(self, *args, **kwargs) | ||
|
|
||
| def get_schedule(self): |
There was a problem hiding this comment.
minor: can you separate in a comment section which methods are "internal" and which ones are required by Celery? To avoid having to go through the Celery docs/code + other implementations to figure this out.
invenio_jobs/services/scheduler.py
Outdated
|
|
||
| def __init__(self, *args: Any, **kwargs: Any) -> None: | ||
| """Initialize the database scheduler.""" | ||
| Scheduler.__init__(self, *args, **kwargs) |
There was a problem hiding this comment.
Suggested change
| Scheduler.__init__(self, *args, **kwargs) | |
| super().__init__(self, *args, **kwargs) |
There was a problem hiding this comment.
if it has to be done like this, perhaps leave a comment in the code ?
yashlamba
force-pushed
the
scheduler
branch
2 times, most recently
from
b2d4f73
to
99aa922
Compare
slint
reviewed
May 28, 2024
yashlamba
force-pushed
the
scheduler
branch
2 times, most recently
from
b88e1f4
to
1c513b2
Compare
|
Rebased on top of #14 |
yashlamba
force-pushed
the
scheduler
branch
3 times, most recently
from
85693ab
to
e1f0281
Compare
invenio_jobs/services/scheduler.py
Outdated
|
|
||
| def __init__(self, *args: Any, **kwargs: Any) -> None: | ||
| """Initialize the database scheduler.""" | ||
| Scheduler.__init__(self, *args, **kwargs) |
There was a problem hiding this comment.
if it has to be done like this, perhaps leave a comment in the code ?
yashlamba
force-pushed
the
scheduler
branch
2 times, most recently
from
abd68db
to
1d204a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6
Depends on: inveniosoftware/invenio-records-resources#579