-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: Implement custom RunScheduler #16
Conversation
ced82ec
to
19abf92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor comments
invenio_jobs/services/scheduler.py
Outdated
"""Initialize the database scheduler.""" | ||
Scheduler.__init__(self, *args, **kwargs) | ||
|
||
def get_schedule(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: can you separate in a comment section which methods are "internal" and which ones are required by Celery? To avoid having to go through the Celery docs/code + other implementations to figure this out.
invenio_jobs/services/scheduler.py
Outdated
|
||
def __init__(self, *args: Any, **kwargs: Any) -> None: | ||
"""Initialize the database scheduler.""" | ||
Scheduler.__init__(self, *args, **kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scheduler.__init__(self, *args, **kwargs) | |
super().__init__(self, *args, **kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it has to be done like this, perhaps leave a comment in the code ?
b2d4f73
to
99aa922
Compare
b88e1f4
to
1c513b2
Compare
Rebased on top of #14 |
85693ab
to
e1f0281
Compare
invenio_jobs/services/scheduler.py
Outdated
|
||
def __init__(self, *args: Any, **kwargs: Any) -> None: | ||
"""Initialize the database scheduler.""" | ||
Scheduler.__init__(self, *args, **kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it has to be done like this, perhaps leave a comment in the code ?
abd68db
to
1d204a2
Compare
Closes #6
Depends on: inveniosoftware/invenio-records-resources#579