You are forced to install all the extras #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Caro <david@dcaro.es>
david-caro
force-pushed
the
defer_imports
branch
from
b49a716
to
ca86fea
Compare
|
LGTM |
|
LGTM too. |
|
@david-caro can you rebase? |
|
@david-caro is away until next week. I can create a new PR based on this one to see if Travis passes. |
|
Replaced by #64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's because the tasks that use them import them in the global scope, making celery fail to start if the deps are not installed.
It should defer the importing and do it only inside the tasks so it only fails when you try to use those 'extra' tasks.