Merge pull request #35 from david-caro/unmask_exception

utils: unmask exception on create_file_name
inveniosoftware · Nov 21, 2017 · 75c0bcf · 75c0bcf
2 parents 4e4f011 + 5481339
commit 75c0bcf
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/invenio_oaiharvester/utils.py b/invenio_oaiharvester/utils.py
@@ -26,6 +26,7 @@
 import os
 import re
 import tempfile
+from contextlib import closing
 from datetime import datetime
 
 from flask import current_app
@@ -170,16 +171,16 @@ def create_file_name(output_dir):
     """
     prefix = 'oaiharvest_' + datetime.now().strftime('%Y-%m-%d') + '_'
 
-    try:
-        temp = tempfile.NamedTemporaryFile(
+    with closing(
+        tempfile.NamedTemporaryFile(
             prefix=prefix,
             suffix='.xml',
             dir=output_dir,
             mode='w+'
         )
+    ) as temp:
         file_name = temp.name[:]
-    finally:
-        temp.close()
+
     return file_name