utils: unmask exception on create_file_name #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failures on travis don't seem to be related to the patch, I'll try to investigate, but if anybody has an idea is more than welcome. |
|
@inveniosoftware/integrators |
|
@inveniosoftware/integrators ping? |
|
@david-caro tests are not passing. |
|
@jirikuncar yes, but it's complaining about a docstring in a function that was not even touched by this patch: |
* When failing to create the `NamedTemporaryFile` on the output dir, the original exception was masked by another one thrown in the `finally` block. (closes inveniosoftware#34) Signed-off-by: David Caro <david@dcaro.es>
david-caro
force-pushed
the
unmask_exception
branch
from
f321da9
to
5481339
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NamedTemporaryFileon the output dir,the original exception was masked by another one thrown in the
finallyblock. (closes Masked exception #34)Signed-off-by: David Caro david@dcaro.es