Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates: translatable text addition #21

Merged
merged 1 commit into from
Dec 2, 2015

Conversation

hachreak
Copy link
Member

@hachreak hachreak commented Dec 2, 2015

Signed-off-by: Leonardo Rossi leonardo.r@cern.ch

{% endblock oauth_controls %}
{% if s.icon %}<i class="{{s.icon}}"></i>{% endif %}
{{s.title}}
{% if s.account %}<i class="fa fa-check" style="color: #5cb85c;"></i>{% endif %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please replace style="color: ... with class="... text-success"

@jirikuncar jirikuncar self-assigned this Dec 2, 2015
@jirikuncar jirikuncar added this to the v1.0.0 milestone Dec 2, 2015
@@ -31,7 +31,7 @@
<span class="pull-right"><i class="{{app_icon}} fa-5x"></i></span>
{%- endif %}
{%- endblock %}
<h3> Sign-up with {{app_title}}!</h3>
<h3> {{ _('Sign-up with %(title)!', title=app_title) }}</h3>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%(title)s?

@hachreak hachreak force-pushed the 12_translate_strings branch 2 times, most recently from f0c2fde to a4f0d92 Compare December 2, 2015 12:38
* Uses gettext function to make template text translatable.
  (addresses inveniosoftware#12)

Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
@jirikuncar jirikuncar merged commit 9be594e into inveniosoftware:master Dec 2, 2015
@hachreak hachreak deleted the 12_translate_strings branch December 4, 2015 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants