Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global: merge admin #40

Merged
merged 2 commits into from
Dec 9, 2015
Merged

global: merge admin #40

merged 2 commits into from
Dec 9, 2015

Conversation

lnielsen
Copy link
Member

@lnielsen lnielsen commented Dec 6, 2015

No description provided.

* Adds Flask-Admin model views registration.

Signed-off-by: Krzysztof Nowak <k.nowak@cern.ch>
@lnielsen lnielsen self-assigned this Dec 6, 2015
@lnielsen lnielsen added this to the v1.0.0 milestone Dec 6, 2015
@@ -39,6 +39,7 @@

from .errors import PIDAlreadyExists, PIDDoesNotExistError, PIDInvalidAction, \
PIDObjectAlreadyAssigned
from flask_babelex import gettext as _
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gettext or lazy_gettext?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be lazy_gettext, but Flask-Admin is not happy about lazy strings so need to figure out a solution.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about _ = lambda x: x and using gettext in templates?

@jirikuncar
Copy link
Member

:shipit:

@classmethod
def as_title(cls, value):
"""Get title for status."""
return dict(cls.titles)[value]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no cover?

Signed-off-by: Lars Holm Nielsen <lars.holm.nielsen@cern.ch>
@lnielsen
Copy link
Member Author

lnielsen commented Dec 9, 2015

Ready

@jirikuncar jirikuncar merged commit 8534499 into inveniosoftware:master Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants