mappings: migrate resource_type to vocbulary style #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppanero
force-pushed
the
facets
branch
4 times, most recently
from
261ba86
to
da5819d
Compare
fenekku
approved these changes
Jun 1, 2021
invenio_rdm_records/records/mappings/v6/rdmrecords/drafts/draft-v2.0.0.json
Outdated
Show resolved
Hide resolved
invenio_rdm_records/records/mappings/v6/rdmrecords/records/record-v2.0.0.json
Outdated
Show resolved
Hide resolved
invenio_rdm_records/records/mappings/v7/rdmrecords/drafts/draft-v2.0.0.json
Outdated
Show resolved
Hide resolved
invenio_rdm_records/records/mappings/v7/rdmrecords/records/record-v2.0.0.json
Outdated
Show resolved
Hide resolved
ppanero
commented
Jun 2, 2021
| system_identity, "resource_types", "rsrct") | ||
|
|
||
|
|
||
| @pytest.fixture(scope="function") |
There was a problem hiding this comment.
Had to make it function scoped and therefore remove it from runnint_app. The issue comes when used along es_clear. Since the vocabulary will be indexed and the labels come from ES, any previous test with es_clear will remove it and it will not be present when needed (e.g. labels). Note: this only happens at tests/resources/ level since es_clear is not used otherwise.
ppanero
commented
Jun 2, 2021
| resource_type_facet = NestedTermsFacet( | ||
| field='metadata.resource_type.type', | ||
| subfield='metadata.resource_type.subtype', | ||
| resource_type_facet = TermsFacet( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #622
Facets are back