-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
global: general improvements #24
Merged
jirikuncar
merged 1 commit into
inveniosoftware:master
from
drjova:global-general-improvements
Sep 15, 2016
Merged
global: general improvements #24
jirikuncar
merged 1 commit into
inveniosoftware:master
from
drjova:global-general-improvements
Sep 15, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b92654
to
e09b695
Compare
c0bc895
to
f6dfd37
Compare
This was referenced Sep 5, 2016
6c3ffdd
to
8bb5e02
Compare
return { | ||
url: url, | ||
method: (method || 'PUT').toUpperCase(), | ||
data: _data, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
124175c
to
5e3b964
Compare
The PR has been updated with a more DRY approach for different use cases, it's possible to change the data and clean logic with a .config([ '$provide', function($provide) {
$provide.decorator('InvenioRecordsAPI', [
'$delegate',
function myServiceDecorator($delegate) {
// keep the existing function
var getData = $delegate.getData;
function newCleanData(data, unwanted) {
// unicorns and stuff
return data;
}
function newGetData(model, extraParams, endpoints) {
var _model = {
metadata: model
};
// More unicorns and stuff
// Pass the arguments to the existing function without re-writting the code
getData.apply($delegate, _model, extraParams, endpoints);
}
// Override the cleanData
$delegate.cleanData = newCleanData;
// Override the getData
$delegate.getData = newGetData;
// return the delegate
return $delegate;
}
]);
}]); |
Signed-off-by: Harris Tzovanakis <me@drjova.com>
5e3b964
to
303e2eb
Compare
👍 LGTM! |
This one works for me and @pamfilos. I think it can go on. |
jirikuncar
approved these changes
Sep 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT merge yet