[Needs discussion]names: adds logging #357
Conversation
jrcastro2
commented
Jul 11, 2024
•
jrcastro2
commented
- NEEDS structlog: add structlog logger factory invenio-logging#75
- NEEDS service: add create update many invenio-records-resources#585
jrcastro2
force-pushed
the
add-orcid-public-data-sync
branch
from
2e8e25b
to
3a8f7c1
Compare
slint
force-pushed
the
add-orcid-public-data-sync
branch
from
3a8f7c1
to
2048618
Compare
jrcastro2
force-pushed
the
add-orcid-public-data-sync
branch
from
2048618
to
56000b8
Compare
slint
force-pushed
the
add-orcid-public-data-sync
branch
from
56000b8
to
2048618
Compare
| orcids_to_sync.extend(process_file(f)) | ||
|
|
||
| def fetch_orcid_data(orcid_to_sync, bucket): | ||
| suffix = orcid_to_sync[-3:] |
There was a problem hiding this comment.
I added a comment there explaining it, the ORCiD information is stored in a xml that we can find in a folder which name is the last 3 digits on the orcid. For instance, this ORCiD info "0000-0001-5109-3700" is located in the folder /700/0000-0001-5109-3700.xml
| "OrcidDataSyncReader downloads one file and therefore does not iterate through items" | ||
| ) | ||
|
|
||
| def read(self, item=None, *args, **kwargs): |
There was a problem hiding this comment.
After checking, looks like that this is probably still not cleaned, requires a bit more ❤️ :)
There was a problem hiding this comment.
Right, it was still a draft PR missing some love as you said. Now it's ready to review, still some improvements can be done such as adding more logging but this is a working MVP IMHO.
setup.cfg
Outdated
| @@ -32,6 +32,10 @@ install_requires = | |||
| invenio-administration>=2.0.0,<3.0.0 | |||
| lxml>=4.5.0 | |||
| PyYAML>=5.4.1 | |||
| awscli>=1.33.23 | |||
There was a problem hiding this comment.
Probably awscli could be removed but the rest were needed, however due to dependency issues between boto3, botocore and commonmet-py, I have replaced them with s3fs which seems to work as fine.
jrcastro2
force-pushed
the
add-orcid-public-data-sync
branch
from
ce55082
to
9b4f9ca
Compare
* Adds delete all values of a vocab to CLI
jrcastro2
force-pushed
the
add-orcid-public-data-sync
branch
from
9b4f9ca
to
00535e0
Compare
jrcastro2
changed the title
