oauth2server: test fix #3379
Closed
oauth2server: test fix #3379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -231,7 +231,7 @@ def test_invalid_authorize_requests(self): | |||
| )) | |||
| self.assertStatus(r, 302) | |||
| next_url, data = self.parse_redirect(r.location) | |||
| self.assertEqual(data['error'], 'unauthorized_client') | |||
There was a problem hiding this comment.
IMHO you should not change the test. (cc @lnielsen)
* Fixes oauth2server test. Signed-off-by: Marco Neumann <marco@crepererum.net>
crepererum
force-pushed
the
fix/oauth2server_test
branch
from
c18713c
to
062059e
Compare
|
OK, so @hachreak tracked down the issue: oauthlib released a new version which is not compatible with our tests. Because this lib is a second order requirement through Flask-OAuthlib, our
This is also related to #2158 which suggest that we should not constraint the version but rather get our tests fixed and finally do the upgrade for |
I would go for number two. WDYT @lnielsen |
|
I vote for option 2 as well, unless someone wants to upgrade Flask-OAuthlib. Disabling the test is not an option in my opinion. Btw, "Fixes oauth2server test." is quite misleading when in fact it's disabling the test ;-) |
hachreak
pushed a commit
to hachreak/invenio
that referenced
this pull request
Jul 21, 2015
* Fixes a maximum version requirement for oauthlib. (closes inveniosoftware#3379) Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
hachreak
pushed a commit
to hachreak/invenio
that referenced
this pull request
Jul 21, 2015
* Fixes a maximum version requirement for oauthlib. (closes inveniosoftware#3379) Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
hachreak
pushed a commit
to hachreak/invenio
that referenced
this pull request
Jul 21, 2015
* Fixes a maximum version requirement for oauthlib. (closes inveniosoftware#3379) Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
hachreak
pushed a commit
to hachreak/invenio
that referenced
this pull request
Jul 21, 2015
* Fixes a maximum version requirement for oauthlib. (closes inveniosoftware#3379) Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
hachreak
pushed a commit
to hachreak/invenio
that referenced
this pull request
Jul 22, 2015
* Fixes a maximum version requirement for oauthlib. (closes inveniosoftware#3379) Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
hachreak
pushed a commit
to hachreak/invenio
that referenced
this pull request
Jul 22, 2015
* Fixes a maximum version requirement for oauthlib. (closes inveniosoftware#3379) Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
hachreak
pushed a commit
to hachreak/invenio
that referenced
this pull request
Jul 22, 2015
* Fixes a maximum version requirement for oauthlib. (closes inveniosoftware#3379) Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
hachreak
pushed a commit
to hachreak/invenio
that referenced
this pull request
Jul 22, 2015
* Fixes a maximum version requirement for oauthlib. (closes inveniosoftware#3379) Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
hachreak
pushed a commit
to hachreak/invenio
that referenced
this pull request
Jul 22, 2015
* Fixes a maximum version requirement for oauthlib. (closes inveniosoftware#3379) Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
hachreak
pushed a commit
to hachreak/invenio
that referenced
this pull request
Jul 22, 2015
* Fixes a maximum version requirement for oauthlib. (closes inveniosoftware#3379) Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
hachreak
pushed a commit
to hachreak/invenio
that referenced
this pull request
Jul 22, 2015
* Fixes a maximum version requirement for oauthlib. (closes inveniosoftware#3379) Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
hachreak
pushed a commit
to hachreak/invenio
that referenced
this pull request
Jul 23, 2015
* Fixes a maximum version requirement for oauthlib. (closes inveniosoftware#3379) Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
jirikuncar
pushed a commit
to jirikuncar/invenio
that referenced
this pull request
Sep 3, 2015
* Fixes a maximum version requirement for oauthlib. (closes inveniosoftware#3379) * Cherry-picked from a3f9db0. Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marco Neumann marco@crepererum.net