inveniogc: tempdir deletion #3558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIX websubmit_icon_creator and websubmit_file_stamper create tempdirs instead of files thus deletion has to be recursive. Addresses inveniosoftware#3556 Signed-off-by: Alexander Wagner <alexander.wagner@desy.de>
|
@tiborsimko do you cherrypick to 1.2 or should I create a second PR for this? |
|
@aw-bib |
tiborsimko
pushed a commit
to tiborsimko/invenio
that referenced
this pull request
Nov 12, 2016
* FIX Fixes garbage collection of temporary directories created by websubmit_icon_creator and websubmit_file_stamper. (closes inveniosoftware#3556) (PR inveniosoftware#3558) Signed-off-by: Alexander Wagner <alexander.wagner@desy.de>
|
Thanks, amended release note message, merging via PR #3716. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX websubmit_icon_creator and websubmit_file_stamper create tempdirs
instead of files thus deletion has to be recursive.
Addresses #3556
Signed-off-by: Alexander Wagner alexander.wagner@desy.de