Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added documentation contribution guide #3955

Closed
wants to merge 1 commit into from
Closed

docs: added documentation contribution guide #3955

wants to merge 1 commit into from

Conversation

vlad-bm
Copy link

@vlad-bm vlad-bm commented Jul 30, 2019

Closes (#3948)

@vlad-bm vlad-bm self-assigned this Jul 30, 2019
@vlad-bm vlad-bm added this to In progress in Files bundle sprint (July 22 to Aug 2) via automation Jul 30, 2019
@vlad-bm vlad-bm marked this pull request as ready for review July 31, 2019 15:22
@vlad-bm vlad-bm moved this from In progress to Pending review in Files bundle sprint (July 22 to Aug 2) Jul 31, 2019
Copy link
Member

@okraskaj okraskaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pair-reviewed with @vladbmihaescu
I think another review would be helpful.

Configuration
=============

Location: :code:`__init__.py`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lnielsen What do you think about this solution? I voted for it because in my opinion without it, it is not obvious where the configuration is located.

docs/community/documentation-style-guide.rst Outdated Show resolved Hide resolved
docs/community/documentation-style-guide.rst Outdated Show resolved Hide resolved
docs/community/documentation-style-guide.rst Outdated Show resolved Hide resolved
docs/community/documentation-style-guide.rst Outdated Show resolved Hide resolved
docs/community/documentation-style-guide.rst Outdated Show resolved Hide resolved
@lnielsen lnielsen moved this from Pending review to Blocked in Files bundle sprint (July 22 to Aug 2) Aug 2, 2019
@lnielsen
Copy link
Member

Closing PR because it's been stale for a long time.

@lnielsen lnielsen closed this Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants