global: updateQueryState support for multiple filters #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topless
changed the title
ntarocco
reviewed
Apr 2, 2020
| * e.g. query = [['file_type', 'pdf'], ['file_type', 'txt']] | ||
| */ | ||
| let tempStateFilters = stateFilters; | ||
| _forEach( |
There was a problem hiding this comment.
can you do simply:
return queryFilters.filter(queryFilter => updateFilter(queryFilter. stateFilters))
?
There was a problem hiding this comment.
This was my initial approach but as we call updateFilter our stateFilters change, so our next updateFilter should be applied on the altered stateFilters and not the initial ones. I can explain in a call if needed.
topless
force-pushed
the
submit-multiple-filters
branch
from
fd43974
to
b37dc8a
Compare
ntarocco
approved these changes
Apr 2, 2020
zzacharo
approved these changes
Apr 2, 2020
- updateQueryState now also accepts array of filters as input
topless
force-pushed
the
submit-multiple-filters
branch
from
b37dc8a
to
e4039bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updateQueryStateaccepts only one filter a time. The intention of this pr is to be able to submit multiple filters at once. This is useful for example when we want to replace a filter.