New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global: fix initial query state values #103

Merged

ntarocco merged 1 commit into inveniosoftware:master from ntarocco:fix-initial-values

Apr 14, 2020

Contributor

ntarocco commented Apr 3, 2020

The initial values for pagination and results per page should be "undefined" as the others, so that:

if the ResultsPerPage or Pagination components are not mounted, the value stays undefined and it is not added to the query string sent to the backend
if the components are mounted, then the defaultValue of the component will be set


          global: fix initial query state values

0f545fc

ntarocco requested a review from zzacharo

April 3, 2020 12:18

ntarocco added the bug label

zzacharo approved these changes

View reviewed changes

ntarocco merged commit 887c0e9 into inveniosoftware:master

ntarocco deleted the fix-initial-values branch

April 14, 2020 16:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment