Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json: add watch/link dist folder #107

Closed
wants to merge 1 commit into from

Conversation

zzacharo
Copy link
Member

@zzacharo zzacharo commented Apr 14, 2020

Copy link
Contributor

@ntarocco ntarocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some researching and testing and it is true that there is no nice solution. All my tests are actually nicely summarized here.
It looks like that a solution is coming with NPM 7, see here.
For the moment, why not changing the app webpack aliases that uses RSK? This works:

alias: {
      // react-searchkit peer dependencies, to avoid duplication
      axios: path.resolve('./node_modules/axios'),
      qs: path.resolve('./node_modules/qs'),
      react: path.resolve('./node_modules/react'),
      'react-dom': path.resolve('./node_modules/react-dom'),
      'react-redux': path.resolve('./node_modules/react-redux'),
      redux: path.resolve('./node_modules/redux'),
      'redux-thunk': path.resolve('./node_modules/redux-thunk'),

@slint
Copy link
Member

slint commented Aug 19, 2020

At the moment to test out changes in cookiecutter/InvenioRDM, these changes help a lot (along with this short guide). I agree it's not the best solution, but I suggest we merge and swap when the next best thing comes :)

@slint slint added this to Backlog in Invenio v3.4 + SemanticUI via automation Aug 19, 2020
@slint slint moved this from Backlog to In progress in Invenio v3.4 + SemanticUI Aug 19, 2020
@ntarocco
Copy link
Contributor

At the moment to test out changes in cookiecutter/InvenioRDM, these changes help a lot (along with this short guide). I agree it's not the best solution, but I suggest we merge and swap when the next best thing comes :)

Be aware that this did not work in react-invenio-app-ils because how npm is resolving the node_modules folder. We add to for aliases, no alternatives.
If it is ok for other projects, I am ok with this!

@lnielsen lnielsen moved this from In progress to Pending review in Invenio v3.4 + SemanticUI Aug 25, 2020
@lnielsen lnielsen added this to Todo in Architects via automation Aug 25, 2020
@ntarocco
Copy link
Contributor

Integrated in: 8802f95

@ntarocco ntarocco closed this Aug 25, 2020
Invenio v3.4 + SemanticUI automation moved this from Pending review to Done Aug 25, 2020
@lnielsen lnielsen moved this from Todo to Done in Architects Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Architects
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants