-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation and upgrade worflows for RDM #4
Conversation
2110ccd
to
fc92a07
Compare
fc92a07
to
cfcd67e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor formulation notes, but the unresolved question section summarizes all the questions I had as well.
|
||
## Motivation | ||
|
||
- As a developer, I want to be able to initialize the RDM file/folder structure, so that I can have a working instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove the "to be able" part to shorten these: "to be able to initialize" -> "to initialize"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I had it just for consistency with other RFCs. Lets discuss IRL
89fba56
to
005af57
Compare
@fenekku Thanks for the review! I fixed/reply to the comments. I also added one unnresolved question that could potentially affect your profiles/falvours RFC. |
An example execution to deploy a development instance would be: | ||
|
||
``` bash | ||
$ invenio-cli rdm init |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be amended. Due to implementation constraints it has to be:
invenio-cli --flavour=rdm init
The rest is not impacted.
Co-Authored-By: fenekku <fenekku@fenekku.com>
005af57
to
a4983ab
Compare
Impotant note: No |
hello guys. i have tried the installation flow for invenio RDM. i dont understand why the invenio cli is out of the project directory. and using pip is not enough to complete the installation flow, its fine when we use the pipenv outside of the project directory but then we will have two pipfiles one inside the project directory and one outside where the invenio-cli is located.
.. |
@mb-wali Thanks a lot for the comments. Much appreciated.
This will be fixed with the november release. I.e. it will be:
and NOT:
I.e. it will work much like |
|
||
Overall design of the installation and upgrade workflows of Invenio RDM. | ||
|
||
## Motivation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this thought only for developers? what about sysadmins?
If I am an institution sysadmin and I simply want to install InvenioRDM as it is. How do I do so?
By install, I mean in a server. Not for development purposes. Is this in the scope of this RFC? Just to setup my brain for the rest of it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RFC should cover both: a developer that wants to run it locally and a sysadmin (what I often call a 'hoster') that just wants to generate a working repo from the get-go. The main difference will be between main application running in containers behind uwsgi (production) or running on host filesystem (development).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
um...ok, then the motivation list should include some As a sysadmin...
:)
Needs updating:
Possible more. |
No description provided.