Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation and upgrade worflows for RDM #4

Merged
merged 7 commits into from
Mar 21, 2024

Conversation

ppanero
Copy link
Member

@ppanero ppanero commented Oct 2, 2019

No description provided.

@ppanero ppanero requested a review from lnielsen October 2, 2019 13:57
@ppanero ppanero changed the title WIP: Installation and upgrade worflows for RDM Installation and upgrade worflows for RDM Oct 2, 2019
Copy link
Contributor

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formulation notes, but the unresolved question section summarizes all the questions I had as well.

rdm/0004-installation-and-upgrade-workflow.md Show resolved Hide resolved

## Motivation

- As a developer, I want to be able to initialize the RDM file/folder structure, so that I can have a working instance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the "to be able" part to shorten these: "to be able to initialize" -> "to initialize"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I had it just for consistency with other RFCs. Lets discuss IRL

rdm/0004-installation-and-upgrade-workflow.md Show resolved Hide resolved
rdm/0004-installation-and-upgrade-workflow.md Show resolved Hide resolved
rdm/0004-installation-and-upgrade-workflow.md Outdated Show resolved Hide resolved
rdm/0004-installation-and-upgrade-workflow.md Outdated Show resolved Hide resolved
rdm/0004-installation-and-upgrade-workflow.md Show resolved Hide resolved
rdm/0004-installation-and-upgrade-workflow.md Outdated Show resolved Hide resolved
rdm/0004-installation-and-upgrade-workflow.md Show resolved Hide resolved
rdm/0004-installation-and-upgrade-workflow.md Outdated Show resolved Hide resolved
@ppanero
Copy link
Member Author

ppanero commented Oct 4, 2019

@fenekku Thanks for the review! I fixed/reply to the comments. I also added one unnresolved question that could potentially affect your profiles/falvours RFC.

rdm/0004-installation-and-upgrade-workflow.md Outdated Show resolved Hide resolved
An example execution to deploy a development instance would be:

``` bash
$ invenio-cli rdm init
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be amended. Due to implementation constraints it has to be:

invenio-cli --flavour=rdm init

The rest is not impacted.

Co-Authored-By: fenekku <fenekku@fenekku.com>
@ppanero
Copy link
Member Author

ppanero commented Oct 31, 2019

Impotant note: No setup.py gets generated by the CLI, which means users will not have the option to extend/add entrypoints with custom development. Shall we allow that?

@lnielsen lnielsen assigned jbenito3 and unassigned ppanero Nov 5, 2019
@mb-wali
Copy link

mb-wali commented Nov 8, 2019

hello guys. i have tried the installation flow for invenio RDM. i dont understand why the invenio cli is out of the project directory. and using pip is not enough to complete the installation flow, its fine when we use the pipenv outside of the project directory but then we will have two pipfiles one inside the project directory and one outside where the invenio-cli is located.
anyway.. it is a bit confusing but. the installation went alright.. also i was able to create the demo records. but when you want to see the specific records for example https://127.0.0.1:5000/records/5 there is an error:

UnboundLocalError
UnboundLocalError: local variable 'pid' referenced before assignment

..
thanks guys.. just wanted to give my update on the installation flow...
Mojib from TUGRAZ.

@lnielsen
Copy link
Member

lnielsen commented Nov 8, 2019

@mb-wali Thanks a lot for the comments. Much appreciated.

  1. why the invenio cli is out of the project directory

This will be fixed with the november release. I.e. it will be:

invenio-cli init
cd my-rdm
invenio-cli build

and NOT:

invenio-cli init
invenio-cli build

I.e. it will work much like npm and similar tools.


Overall design of the installation and upgrade workflows of Invenio RDM.

## Motivation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this thought only for developers? what about sysadmins?
If I am an institution sysadmin and I simply want to install InvenioRDM as it is. How do I do so?
By install, I mean in a server. Not for development purposes. Is this in the scope of this RFC? Just to setup my brain for the rest of it :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RFC should cover both: a developer that wants to run it locally and a sysadmin (what I often call a 'hoster') that just wants to generate a working repo from the get-go. The main difference will be between main application running in containers behind uwsgi (production) or running on host filesystem (development).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

um...ok, then the motivation list should include some As a sysadmin... :)

@ntarocco ntarocco added the RDM Invenio RDM label Apr 22, 2020
@ppanero
Copy link
Member Author

ppanero commented Jun 1, 2020

Needs updating:

  • .invenio.private files.

Possible more.

@lnielsen lnielsen merged commit 094891c into inveniosoftware:master Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RDM Invenio RDM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants