Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inventory browser #193

Merged
merged 177 commits into from
Feb 15, 2020
Merged

inventory browser #193

merged 177 commits into from
Feb 15, 2020

Conversation

maxlath
Copy link
Member

@maxlath maxlath commented Feb 15, 2020

replaces the old /inventory interface by a new InventoryLayout based on InventoryBrowser, introducing many things, among which:

  • a table view (ItemsTable) that allows mass items edits 🎉
  • items filter by authors, genres, and subjects 🎉
  • a map displaying both public users and groups
  • get rids of /network layout (its feature where integrated to /inventory/network and /inventory/public)
  • replace the icon nav bar by a slimmed top bar menu, making the logout button more accessible (among other things)
  • get rid to the (bloated) settings menu

and more! ^^

making sure it always returns a promise, including when their is no more items to fetch
addressing #121
…r own module

to make the view file shorter/more understandible
…erver

- worksTree properties URIs are replaced by names (author, genre, subject)
  to decrease the amount of keys we have to jungle with
to underline the link with an event and help distinguish between all those functions names
- introducing a system of tabs, highlighting the user own inventory
- prepare the view to display the inventory browser by default
- items_list -> items_cascade
- item_figure -> item_card
- move Masonry from bower to npm package
so that re-render almost feels like instant in most cases
instead of the previous almost half a second delay, that felt somewhat slow
- avoid modifying @itemsByDate to be able to reuse it later
- splice on a private array to not mess with items_table selectors
so that clicking on it when disable feels like it is really disabled
instead of asking for the confirmation of the deletion of 0 items
…eight

meaning that the height is smaller if the avatar fails to load
Copy link
Contributor

@jum-s jum-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

- invite by email => show inviteByEmail layout in a modal
- search user => open live search with the user section preselected
- find on map => show /inventory/public
- create => show create group layout in a modal
- search group => open live search with the group section preselected
- find on map => show /inventory/public?filter=groups
to make small screen display simpler to handle
now that most features are available from inventory_network_tab
so that the error can be handled by views
to keep in sync with unfriended users
for cases when app.relations or app.groups aren't defined yet
as it can happen before resolution of
      app.request 'wait:for', 'relations'
      app.request 'wait:for', 'groups'
as being told "friends: nothing here" isn't exactly nice ;)
following The Great Purge of e3abf50
@maxlath maxlath merged commit 91f4dd2 into master Feb 15, 2020
@maxlath maxlath deleted the inventory-browser branch February 16, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants