-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inventory browser #193
Merged
Merged
inventory browser #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making sure it always returns a promise, including when their is no more items to fetch addressing #121
…r own module to make the view file shorter/more understandible
…erver - worksTree properties URIs are replaced by names (author, genre, subject) to decrease the amount of keys we have to jungle with
to underline the link with an event and help distinguish between all those functions names
- introducing a system of tabs, highlighting the user own inventory - prepare the view to display the inventory browser by default
- items_list -> items_cascade - item_figure -> item_card - move Masonry from bower to npm package
…ed data directly on first render
makes everything simpler
so that re-render almost feels like instant in most cases instead of the previous almost half a second delay, that felt somewhat slow
- avoid modifying @itemsByDate to be able to reuse it later - splice on a private array to not mess with items_table selectors
…ore items to select
so that clicking on it when disable feels like it is really disabled instead of asking for the confirmation of the deletion of 0 items
…eight meaning that the height is smaller if the avatar fails to load
jum-s
approved these changes
Feb 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
- invite by email => show inviteByEmail layout in a modal - search user => open live search with the user section preselected - find on map => show /inventory/public
- create => show create group layout in a modal - search group => open live search with the group section preselected - find on map => show /inventory/public?filter=groups
to make small screen display simpler to handle
now that most features are available from inventory_network_tab
so that the error can be handled by views
to keep in sync with unfriended users
for cases when app.relations or app.groups aren't defined yet as it can happen before resolution of app.request 'wait:for', 'relations' app.request 'wait:for', 'groups'
as being told "friends: nothing here" isn't exactly nice ;)
following The Great Purge of e3abf50
maxlath
force-pushed
the
inventory-browser
branch
from
February 15, 2020 12:35
c5dade8
to
cd9a403
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces the old
/inventory
interface by a newInventoryLayout
based onInventoryBrowser
, introducing many things, among which:ItemsTable
) that allows mass items edits 🎉/network
layout (its feature where integrated to/inventory/network
and/inventory/public
)and more! ^^