recover polyfills #324
Merged
recover polyfills #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jum-s
approved these changes
Jul 7, 2022
The previous assumption that they were automatically added by babel was wrong: the `useBuiltIns` parameter needs to be set and core-js is required
Only adding assumptions that are 99.999% certain to ever cause problem in this codebase: - noDocumentAll: can't imagine a use case involving `documenta.all` - noNewArrows: all constructors in this code base are defined by libraries (Backbone, Svelte)
to make spotting unsupported features easier Dropping support on IE 11 as this plugin shows that it's not adding to much polyfills to the common bundle Also dropping op_mini as the support data can apparently not be trusted compat-table/compat-table#1057
…dead and thus already excluded
as we are never iterating over DOM collections see zloirock/core-js#1003
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We lost polyfills when we did the migration to Webpack #229 (accidentally, as I thought that was part of the babel magic by default).
exploration
the options I could identify regarding our polyfill policy:
proposition
I would go with option 3, and that's what this PR implements. It brings back polyfills to support a shortlist of browsers (defined by rules in
package.json#browserslist), generating a ~101kb minified/~35kb compressed polyfill bundle that would be shipped to all users.