Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build system updates #1063

Merged
merged 81 commits into from Nov 3, 2020
Merged

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Oct 20, 2020

This PR represents a major change to the way that builds operate:

Stock gets allocated against a build output (which is a StockItem). There can be multiple build outputs per build, allowing for partial build completion, and also allowing for tracked stock item to be installed inside a particular "output" of the build process.

@SchrodingersGat SchrodingersGat marked this pull request as draft October 20, 2020 12:29
- Keeps track of how many outputs have been produced
- Will not be directly editable by the user
- Yay, the editor now highlights code properly!
- Add option to calculate required quantity against a particular build output, not just the build
TODO: Needs to describe in the confirmation dialog what is going to happen!
# Conflicts:
#	InvenTree/locale/de/LC_MESSAGES/django.mo
#	InvenTree/locale/de/LC_MESSAGES/django.po
#	InvenTree/locale/en/LC_MESSAGES/django.po
#	InvenTree/locale/es/LC_MESSAGES/django.po
#	InvenTree/templates/js/bom.js
# Conflicts:
#	InvenTree/InvenTree/views.py
#	InvenTree/build/views.py
#	InvenTree/locale/de/LC_MESSAGES/django.po
#	InvenTree/locale/en/LC_MESSAGES/django.po
#	InvenTree/locale/es/LC_MESSAGES/django.po
#	InvenTree/order/views.py
#	InvenTree/part/api.py
#	InvenTree/part/views.py
#	InvenTree/templates/js/bom.js
… build

- Also some refactoring of how forms are handled and saved
- Grouped rows were not displaying the part name
- Might still need to be a background task at some point..
- Updating forms, a lot has changed!
@SchrodingersGat SchrodingersGat marked this pull request as ready for review November 3, 2020 09:18
@SchrodingersGat SchrodingersGat added the enhancement This is an suggested enhancement or new feature label Nov 3, 2020
@SchrodingersGat SchrodingersGat merged commit 1e844c6 into inventree:master Nov 3, 2020
@SchrodingersGat SchrodingersGat deleted the build-fixes branch November 3, 2020 11:59
@eeintech
Copy link
Contributor

eeintech commented Nov 3, 2020

@SchrodingersGat I haven't tested this yet but I've noticed that you had removed the post_save method in ajax views, which broke #1048 after it was merged as it relied on this method to save the model... What was the reason for removing it? pre_save was also removed it seems.

Edit: restored the method in #1099

@SchrodingersGat
Copy link
Member Author

See comments in #1099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an suggested enhancement or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to modify a completed build Partial build completion Build allocation ideas
2 participants