Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webp image support #2993

Merged
merged 27 commits into from
May 18, 2022
Merged

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented May 15, 2022

Currently the docker install does not support webp images, while some bare-metal installs do.

Given the popularity of webp images, especially among electronics distributors, this PR adds (and tests) support for webp

Closes #2988

@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed docker Docker / docker-compose labels May 15, 2022
@SchrodingersGat SchrodingersGat added this to the 0.7.0 milestone May 15, 2022
@SchrodingersGat SchrodingersGat added the enhancement This is an suggested enhancement or new feature label May 15, 2022
Copy link
Member

@matmair matmair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one - should catch some docker problems sooner

@SchrodingersGat
Copy link
Member Author

@matmair interestingly some tests have already failed when building under docker

image

The environment variables test is failing. Any thoughts on how to address this one?

@matmair
Copy link
Member

matmair commented May 15, 2022

@SchrodingersGat could you merge in recent changes? The import should work in alpines version of python3

@SchrodingersGat
Copy link
Member Author

Annoyingly this EnvironmentVarGuard import issue is still hanging around. I can't import test.support in any version of python I try.. Any ideas?

@matmair
Copy link
Member

matmair commented May 16, 2022

@SchrodingersGat I will have a look at that.

@matmair
Copy link
Member

matmair commented May 16, 2022

@SchrodingersGat working on this on my fork:
https://github.com/matmair/inventree/tree/webp-support will ping you once it runs.

@matmair
Copy link
Member

matmair commented May 16, 2022

@SchrodingersGat can you try merging my branch into yours?

@SchrodingersGat
Copy link
Member Author

@matmair still no luck. What version of python are you running?

@matmair
Copy link
Member

matmair commented May 16, 2022

3.8 - but this function was introduced in 3.2 . I do not get it

@SchrodingersGat
Copy link
Member Author

SchrodingersGat commented May 17, 2022

Huh, it appears that the inventree-python library is installing a library "test" into the venv which is overriding the default test package install:

image

image

@SchrodingersGat
Copy link
Member Author

Well progress, of sorts.. I've fixed the inventree-python issue, but now getting a new error message:

image

@matmair
Copy link
Member

matmair commented May 17, 2022

@SchrodingersGat python packages/imports are sometimes... flawed

@SchrodingersGat
Copy link
Member Author

@matmair would you be ok with changing this test to not use test.support module? It is not recommended for public consumption

Maybe something like this?

@matmair
Copy link
Member

matmair commented May 17, 2022

@SchrodingersGat I was not aware of this option. Seems like a good solution.

@matmair
Copy link
Member

matmair commented May 18, 2022

@SchrodingersGat please merge again from my branch

@SchrodingersGat
Copy link
Member Author

Let's see how we go this time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed docker Docker / docker-compose enhancement This is an suggested enhancement or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Support webp images
2 participants