-
-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webp image support #2993
webp image support #2993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one - should catch some docker problems sooner
@matmair interestingly some tests have already failed when building under docker The environment variables test is failing. Any thoughts on how to address this one? |
@SchrodingersGat could you merge in recent changes? The import should work in alpines version of python3 |
Annoyingly this |
@SchrodingersGat I will have a look at that. |
@SchrodingersGat working on this on my fork: |
@SchrodingersGat can you try merging my branch into yours? |
@matmair still no luck. What version of python are you running? |
3.8 - but this function was introduced in 3.2 . I do not get it |
@SchrodingersGat python packages/imports are sometimes... flawed |
@matmair would you be ok with changing this test to not use Maybe something like this? |
@SchrodingersGat I was not aware of this option. Seems like a good solution. |
@SchrodingersGat please merge again from my branch |
# Conflicts: # InvenTree/InvenTree/tests.py
Let's see how we go this time |
Currently the docker install does not support webp images, while some bare-metal installs do.
Given the popularity of webp images, especially among electronics distributors, this PR adds (and tests) support for webp
Closes #2988