Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange rate emergency fix #5632

Merged
merged 18 commits into from
Oct 3, 2023

Conversation

matmair
Copy link
Contributor

@matmair matmair commented Sep 28, 2023

This PR switches the default exchange backend to frankfurter.app
Closes #5631

@matmair matmair added bug Identifies a bug which needs to be addressed backport-to-0.12.x labels Sep 28, 2023
@matmair matmair added this to the 0.12.8 milestone Sep 28, 2023
@matmair matmair self-assigned this Sep 28, 2023
@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for inventree canceled.

Name Link
🔨 Latest commit ab67c32
🔍 Latest deploy log https://app.netlify.com/sites/inventree/deploys/651b571d3a91c60008b00eb1

@matmair matmair mentioned this pull request Sep 28, 2023
@matmair
Copy link
Contributor Author

matmair commented Sep 28, 2023

This can only be merged after #5628

@matmair matmair marked this pull request as ready for review September 28, 2023 12:00
@SchrodingersGat SchrodingersGat added the backport Apply this label to a PR to enable auto-backport action label Sep 28, 2023
@SchrodingersGat
Copy link
Member

SchrodingersGat commented Sep 28, 2023

Nice quick patch, very much appreciated :)

@wolflu05
Copy link
Contributor

Maybe we should make this API url configurable, and default to frankfurter. That way ppl can host their own currency api server if they want to.

@SchrodingersGat
Copy link
Member

Maybe we should make this API url configurable, and default to frankfurter. That way ppl can host their own currency api server if they want to.

I like the idea of adding more options - as a future PR. The focus here should be on getting this merged in ASAP.

For future reference, I would like to see:

  • Different backends supported (with potential for users to supply API keys if they have them)
  • Allow exchange rates to be edited manually (no external updates)
  • Potentially custom plugins can be used to fetch exchange rates

@SchrodingersGat
Copy link
Member

@matmair any chance to look at the errors here? Would be great to release this one ASAP

@SchrodingersGat SchrodingersGat added the pricing Pricing functionality label Oct 2, 2023
@SchrodingersGat
Copy link
Member

@matmair very nice work. Are there any references in the documentation to the exchange rate system? If not, we should probably add something (in a separate PR)

@SchrodingersGat SchrodingersGat merged commit 30cf97d into inventree:master Oct 3, 2023
21 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

💔 All backports failed

Status Branch Result
0.12.x Backport failed because of merge conflicts

You might need to backport the following PRs to 0.12.x:
- Email fix (#5396)

Manual backport

To create the backport manually run:

backport --pr 5632

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

SchrodingersGat pushed a commit to SchrodingersGat/InvenTree that referenced this pull request Oct 3, 2023
@SchrodingersGat
Copy link
Member

Backport to stable branch - #5650

SchrodingersGat added a commit that referenced this pull request Oct 3, 2023
Co-authored-by: Matthias Mair <code@mjmair.com>
@matmair matmair deleted the exchange-rate-emergency-fix branch October 3, 2023 05:25
@matmair
Copy link
Contributor Author

matmair commented Oct 3, 2023

@SchrodingersGat none that I am aware of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Apply this label to a PR to enable auto-backport action bug Identifies a bug which needs to be addressed pricing Pricing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Exchange rate provider is closed now
3 participants