Move broken plugin samples to disabled folders #5642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for inventree canceled.
|
matmair
changed the title
|
LGTM, thanks @matmair |
|
@SchrodingersGat hopefully this helps with debugging #5509 #5632 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the broken plugin samples out of default samples to make tests faster and considerably shorten the action run logs (they are currently mainly the intentional raise and intentional reload of broken files and broken samples).
The broken samples should only run once as that is enough to get coverage and validate functionality.
A small change is needed due to the removal of the constant double-reloading: Tests that add new plugins (like the
test_folder_loadingtest) need to intentionally trigger the collection of plugins.