Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test coverage #6945

Merged
merged 46 commits into from
Apr 8, 2024
Merged

Fix test coverage #6945

merged 46 commits into from
Apr 8, 2024

Conversation

matmair
Copy link
Contributor

@matmair matmair commented Apr 3, 2024

It seems that #5582 has reduced coverage due to leaving some apps tests untouched.

This PR:

  • removes unnecessary artefact steps to preserve resources
  • adds a mechanism that forces almost all ci steps to run if the PR has either the dependency or full-run label
  • sets up coverage source and apps correctly
  • re-adds migration testing coverage

@matmair matmair added the CI CI / unit testing ecosystem label Apr 3, 2024
@matmair matmair marked this pull request as draft April 3, 2024 18:13
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit df45539
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6613c319e88b5a000866660f

@matmair matmair closed this Apr 3, 2024
@matmair matmair reopened this Apr 3, 2024
@matmair matmair added dependency Relates to a project dependency full-run Always do a full QC CI run and removed dependency Relates to a project dependency labels Apr 3, 2024
@matmair matmair added this to the 0.15.0 milestone Apr 5, 2024
@matmair matmair self-assigned this Apr 5, 2024
@matmair
Copy link
Contributor Author

matmair commented Apr 5, 2024

CI seems to only fail because of #6968

@matmair matmair closed this Apr 5, 2024
@matmair matmair reopened this Apr 5, 2024
matmair added a commit to matmair/InvenTree that referenced this pull request Apr 7, 2024
see inventree#6945 for a possibility to get it up again
SchrodingersGat pushed a commit that referenced this pull request Apr 7, 2024
* add codecov upload

* add to readme

* add flags

* dummy change

* dummy change

* switch to inventree org

* add codecov yaml

* lower threshold (for now)
see #6945 for a possibility to get it up again
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.98%. Comparing base (cc045bc) to head (df45539).

Files Patch % Lines
tasks.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6945      +/-   ##
==========================================
+ Coverage   83.57%   85.98%   +2.41%     
==========================================
  Files         803      875      +72     
  Lines       39493    40864    +1371     
  Branches        0      283     +283     
==========================================
+ Hits        33005    35136    +2131     
+ Misses       6488     5655     -833     
- Partials        0       73      +73     
Flag Coverage Δ
backend 85.44% <87.50%> (+1.87%) ⬆️
migrations 42.56% <12.50%> (?)
pui 49.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matmair matmair marked this pull request as ready for review April 8, 2024 07:14
@matmair matmair closed this Apr 8, 2024
@matmair matmair reopened this Apr 8, 2024
@matmair
Copy link
Contributor Author

matmair commented Apr 8, 2024

@SchrodingersGat this is ready for merge!

@SchrodingersGat SchrodingersGat merged commit 4adce85 into inventree:master Apr 8, 2024
30 of 32 checks passed
@SchrodingersGat SchrodingersGat deleted the more-cov branch April 8, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI / unit testing ecosystem full-run Always do a full QC CI run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants