Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xml for coverage info #6947

Merged
merged 71 commits into from Apr 9, 2024
Merged

Conversation

matmair
Copy link
Member

@matmair matmair commented Apr 3, 2024

This PR improve python coverage accuracy for coveralls to keep if comparable with codecov; especially coverage on multilines. Follow up to #6945

@matmair matmair marked this pull request as draft April 3, 2024 22:42
@matmair matmair self-assigned this Apr 3, 2024
@matmair matmair added the CI CI / unit testing ecosystem label Apr 3, 2024
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit c295d24
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66141dbc54710200083a0f17

@matmair
Copy link
Member Author

matmair commented Apr 3, 2024

this messes with codecov settings - do not merge

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.34%. Comparing base (4adce85) to head (be6e318).

❗ Current head be6e318 differs from pull request most recent head c295d24. Consider uploading reports for the commit c295d24 to get more accurate results

Files Patch % Lines
tasks.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6947      +/-   ##
==========================================
- Coverage   85.44%   84.34%   -1.10%     
==========================================
  Files         803      873      +70     
  Lines       39492    40798    +1306     
  Branches        0      283     +283     
==========================================
+ Hits        33742    34412     +670     
- Misses       5750     6313     +563     
- Partials        0       73      +73     
Flag Coverage Δ
backend 85.54% <87.50%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matmair matmair marked this pull request as ready for review April 8, 2024 16:39
@matmair
Copy link
Member Author

matmair commented Apr 8, 2024

Read for review

@SchrodingersGat
Copy link
Member

So many commits for such a small overall change :)

@SchrodingersGat SchrodingersGat merged commit 8d41234 into inventree:master Apr 9, 2024
23 checks passed
@SchrodingersGat SchrodingersGat deleted the cov-use-xml branch April 9, 2024 00:33
@matmair
Copy link
Member Author

matmair commented Apr 9, 2024

The smaller the final diff the happier I am ;-)
This revealed a lot of holes in coverage where coveralls falsely assumed statements were covered but codecov showed they were not. Now the score on coveralls is far more acurate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI / unit testing ecosystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants