Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golang unit tests failed #6108

Closed
nqb opened this issue Jan 27, 2021 · 5 comments · Fixed by #6110
Closed

Golang unit tests failed #6108

nqb opened this issue Jan 27, 2021 · 5 comments · Fixed by #6110
Assignees
@jrouzierinverse
Labels
Type: Bug
Milestone
PacketFence-11.0

Comments

@nqb
Copy link
Contributor

nqb commented Jan 27, 2021

Describe the bug
Since merge of #6083 and after upgrade to Golang 1.15 (see #6044).

Golang unit tests in failed state.

Latest pipeline: https://gitlab.com/inverse-inc/packetfence/-/jobs/988996303#L285
@nqb nqb added the Type: Bug label Jan 27, 2021
@nqb nqb added this to the PacketFence-11.0 milestone Jan 27, 2021
@nqb nqb mentioned this issue Jan 28, 2021
Merged
@nqb
Copy link
Contributor Author

nqb commented Jan 28, 2021

There is still some issues with Golang unit tests: https://gitlab.com/inverse-inc/packetfence/-/jobs/991459167#L898

I also noticed an additional Golang unit test that failed on Debian (go/caddy/wgorchestrator) and not on CentOS: https://gitlab.com/inverse-inc/packetfence/-/jobs/991459176#L545

@jrouzierinverse
Copy link
Member

This is fixed by dee02f4 647a2fb b8caaa8

@nqb nqb reopened this Feb 1, 2021
@nqb
Copy link
Contributor Author

nqb commented Feb 1, 2021

Issue is fixed on CentOS 7 but one Golang unit test on Debian is still in failed state (go/caddy/wgorchestrator). See https://gitlab.com/inverse-inc/packetfence/-/jobs/998286330#L547

satkunas pushed a commit that referenced this issue Feb 8, 2021
@jrouzierinverse @satkunas
Allow CategoryID to be returned as a number or a string
6ab423c 
Fixes #6108
@nqb nqb reopened this Feb 16, 2021
@nqb
Copy link
Contributor Author

nqb commented Feb 16, 2021

@jrouzierinverse: still failing on Debian.

@nqb
Copy link
Contributor Author

nqb commented Apr 8, 2021

No more relevant since merge of #6161

@nqb nqb closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrouzierinverse jrouzierinverse

Labels
Type: Bug
Projects
None yet
Milestone
PacketFence-11.0
Development

Successfully merging a pull request may close this issue.

fix/6108 inverse-inc/packetfence
2 participants
@jrouzierinverse @nqb