feature/go-version-1.15 #6044
Merged
feature/go-version-1.15 #6044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build pass https://gitlab.com/inverse-inc/packetfence/-/pipelines/233066239 , is it ok to merge ? |
|
I'd say lets go, we just need to fix the conflicts and ensure that it still builds and I think we're all good to give it a try in devel |
|
@fdurand and @julsemaan, Golang is installed in Docker images used to build PacketFence packages when you we build Docker images (in I run that job directly on devel: https://gitlab.com/inverse-inc/packetfence/-/jobs/988861139 If this job works, all new builds will rely on Golang 1.15 (not the case at the moment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to go version 1.15
NEWS file entries
Enhancements
Issue
Fixes #5933
Delete branch after merge
NO
Checklist