Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sponsor registration: notes field can't be used on captive portal #6385

Closed
nqb opened this issue Jun 2, 2021 · 3 comments · Fixed by #7313
Closed

Sponsor registration: notes field can't be used on captive portal #6385

nqb opened this issue Jun 2, 2021 · 3 comments · Fixed by #7313

Comments

@nqb
Copy link
Contributor

nqb commented Jun 2, 2021

Describe the bug
When doing sponsor registration on captive portal using portal modules, you can specify "notes" field as a mandatory field. It could be used to let user specify some motivations related to its registration.

However, when doing sponsor registration, PacketFence automatically write some informations into "Notes" field. Consequently, notes entered by user are lost.

To Reproduce
Steps to reproduce the behavior:

  1. Create a portal module that use default sponsor source with "notes" as a mandatory field
  2. Define a connection profile which use your new portal module
  3. Add "Mark as sponsor" right to admin user
  4. Try to register on captive portal using sponsor source with admin user
  5. Add some content into notes field
  6. Check value of "notes" field in PacketFence web admin after node has been registered

=> It contains "sponsored .."

Expected behavior
We should keep notes entered by user.

@jrouzierinverse
Copy link
Member

The note is used record the Date of arrival.
Maybe we should add the date the user was sponsored in the person table.
To avoid updating the note.

@nqb
Copy link
Contributor Author

nqb commented Aug 12, 2022

Agree @jrouzierinverse, it could make more sense.

@jrouzierinverse
Copy link
Member

Let's add this as a new feature for 12.1

@nqb nqb mentioned this issue Oct 28, 2022
3 tasks
JeGoi added a commit that referenced this issue Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants