Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/6385 #7313

Merged
merged 6 commits into from
Oct 28, 2022
Merged

fix/6385 #7313

merged 6 commits into from
Oct 28, 2022

Conversation

jrouzierinverse
Copy link
Member

@jrouzierinverse jrouzierinverse commented Oct 27, 2022 •
edited by nqb
Loading

Description

Don't use notes for tracking the sponsered date.

Impacts

The sponsor work flow.

Issues

fixes #6385

Delete branch after merge

YES

Checklist

(REQUIRED) - [yes, no or n/a]

  • Document the feature
  • Add unit tests
  • Add acceptance tests (TestLink)

NEWS file entries

Enhancements

  • Track the sponspored date into the database.

@jrouzierinverse jrouzierinverse added this to the PacketFence-12.1 milestone Oct 27, 2022
JeGoi
JeGoi requested changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@JeGoi JeGoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor issues with variables.
Then it is fine for me.
Thank you

html/pfappserver/root/src/views/Users/_config/index.js Outdated Show resolved Hide resolved
...captive-portal/lib/captiveportal/PacketFence/DynamicRouting/Module/Authentication/Sponsor.pm Outdated Show resolved Hide resolved
...captive-portal/lib/captiveportal/PacketFence/DynamicRouting/Module/Authentication/Sponsor.pm Outdated Show resolved Hide resolved
...captive-portal/lib/captiveportal/PacketFence/DynamicRouting/Module/Authentication/Sponsor.pm Outdated Show resolved Hide resolved
fdurand
fdurand requested changes Oct 28, 2022
View reviewed changes
db/upgrade-X.X-X.Y.sql Outdated Show resolved Hide resolved
@JeGoi JeGoi self-requested a review October 28, 2022 15:54
@JeGoi JeGoi merged commit 10ef626 into devel Oct 28, 2022
@JeGoi JeGoi deleted the fix/6385 branch October 28, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdurand fdurand fdurand approved these changes

@JeGoi JeGoi JeGoi approved these changes

Assignees

@JeGoi JeGoi

Labels
Priority: Medium
Projects
None yet
Milestone
PacketFence-12.1
Development

Successfully merging this pull request may close these issues.

Sponsor registration: notes field can't be used on captive portal
3 participants
@jrouzierinverse @fdurand @JeGoi