Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/form-captive-portal #1666

Merged

Conversation

jrouzierinverse
Copy link
Member

Description

Allow captiveportal::Form::Authentication to be customize

NEWS file entries

Enhancements
++++++++++++

  • Allow captiveportal::Form::Authentication to be customize

Delete branch after merge

NO

@jrouzierinverse
Copy link
Member Author

The packaging to avoid overriding customizations still needs to be done.

@jrouzierinverse jrouzierinverse added this to the PacketFence-6.4 milestone Oct 16, 2016
@fdurand
Copy link
Member

fdurand commented Oct 28, 2016

seems to be ok since you are just moving files.

@extrafu
Copy link
Member

extrafu commented Nov 1, 2016

Can this be tested?

@fdurand
Copy link
Member

fdurand commented Nov 1, 2016

Need a rebase

@jrouzierinverse
Copy link
Member Author

done

James Rouzier
jrouzier@inverse.ca :: +1.514.447.4918 (x115) :: http://www.inverse.ca
Inverse inc. :: Leaders behind SOGo (http://www.sogo.nu) and PacketFence (http://www.packetfence.org)

On 2016-11-01 11:45 AM, Durand wrote:

Need a rebase


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1666 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACmeMWNl85X-Wa3Kz5q4RtVYdJtt8UZ4ks5q516AgaJpZM4Jp-3J.

@fdurand
Copy link
Member

fdurand commented Nov 1, 2016

Can you add that in packetfence.spec:
%config(noreplace) html/captive-portal/lib/captiveportal/Form/Authentication.pm
%config(noreplace) html/captive-portal/lib/captiveportal/Form/Field/AUP.pm
%config(noreplace) html/captive-portal/lib/captiveportal/Form/Widget/Field/AUP.pm
and that in packetfence.conffiles:
html/captive-portal/lib/captiveportal/Form/Authentication.pm
html/captive-portal/lib/captiveportal/Form/Field/AUP.pm
html/captive-portal/lib/captiveportal/Form/Widget/Field/AUP.pm

@jrouzierinverse
Copy link
Member Author

done

James Rouzier
jrouzier@inverse.ca :: +1.514.447.4918 (x115) :: http://www.inverse.ca
Inverse inc. :: Leaders behind SOGo (http://www.sogo.nu) and PacketFence (http://www.packetfence.org)

On 2016-11-01 1:32 PM, Durand wrote:

Can you add that in packetfence.spec:
%config(noreplace)
html/captive-portal/lib/captiveportal/Form/Authentication.pm
%config(noreplace) html/captive-portal/lib/captiveportal/Form/Field/AUP.pm
%config(noreplace)
html/captive-portal/lib/captiveportal/Form/Widget/Field/AUP.pm
and that in packetfence.conffiles:
html/captive-portal/lib/captiveportal/Form/Authentication.pm
html/captive-portal/lib/captiveportal/Form/Field/AUP.pm
html/captive-portal/lib/captiveportal/Form/Widget/Field/AUP.pm


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1666 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACmeMUhCMp0eGHPFvQLRX401vklprBuoks5q53fBgaJpZM4Jp-3J.

@fdurand
Copy link
Member

fdurand commented Nov 1, 2016

Tested , works, merge

@fdurand fdurand merged commit d4b042d into inverse-inc:devel Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants