Fix/2377 fix permissions from gui #2398
Conversation
| @@ -502,6 +502,16 @@ sub fix_file_permissions { | |||
| pf_run('sudo /usr/local/pf/bin/pfcmd fixpermissions file "' . $file . '"'); | |||
| } | |||
|
|
|||
| =item fix_files_permissions | |||
There was a problem hiding this comment.
Maybe a better name fix_permissions_all.
I find the name to close to the other function.
|
@jrouzierinverse, the checkup already had that behavior to prevent doing it 5 times if the user wanted to refer to it 5 different times given it takes a lot of time to accomplish. IMO, I'd leave it to that behavior for all items of this menu but in the end you guys can decide together what is best |
|
There was an additional issue there that was not addressed |
|
There should be at least a way to clear and rerun the results since some people would not know how rerun those commands. |
|
I agree with @jrouzierinverse. @dwlfrth: let me know if you need help. |
|
I didn't clear your review, I just approved the PR since my review was requested on it yesterday If you look, yours is still in place and left the PR in 'Changes requested' |
|
@julsemaan Sorry you are correct |
|
No problem, this gave me an idea for your next Christmas gift: |
|
Thanks! |
|
@jrouzierinverse maybe you could have a look at that additional issue (Option to have it automated when we detect a file permission issue.) |
|
GUI is adjusted. |
Description
Add the ability to "fix permissions" from the GUI
Impacts
Admin GUI
Issue
fixes #2377
Delete branch after merge
YES
NEWS file entries
Enhancements
Bug Fixes