Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FixedRole portal module #2490

Merged
merged 2 commits into from
Nov 23, 2017
Merged

FixedRole portal module #2490

merged 2 commits into from
Nov 23, 2017

Conversation

fdurand
Copy link
Member

@fdurand fdurand commented Jul 17, 2017 •
edited
Loading

Description

Portal module to keep the previous role defined if this role is in a specific list.

Impacts

PORTAL authentication workflow

Delete branch after merge

YES

NEWS file entries

New Features

  • New portal module to keep the previous role if this role is in a list.

@fdurand fdurand changed the title First draft of Roleinstone Roleinstone portal module Jul 17, 2017
@fdurand fdurand added this to the PacketFence-7.3 milestone Jul 24, 2017
@julsemaan julsemaan self-requested a review August 22, 2017 14:29
julsemaan
julsemaan reviewed Aug 24, 2017
View reviewed changes
Copy link
Collaborator

@julsemaan julsemaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the RoleInStone name

Sounds fancy and all but not sure a non-Inverse user would understand what it is.

Maybe FixedRole or something like that would be more accurate for a name

html/pfappserver/lib/pfappserver/Form/Config/PortalModule/RoleInStone.pm Outdated
type => 'Select',
multiple => 1,
label => 'Roles',
options_method => \&options_admin_role,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would be options_stone_role

html/pfappserver/lib/pfappserver/Form/Config/PortalModule/RoleInStone.pm Outdated
return qw(stone_roles);
}

sub options_admin_role {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

options_stone_role

@dwlfrth dwlfrth self-assigned this Sep 28, 2017
@fdurand fdurand changed the title Roleinstone portal module FixedRole portal module Oct 3, 2017
@julsemaan julsemaan merged commit edacfb3 into devel Nov 23, 2017
@fdurand fdurand deleted the feature/role_in_stone branch February 15, 2018 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julsemaan julsemaan julsemaan left review comments

Assignees

@dwlfrth dwlfrth

Labels
Status: For review Type: Feature / Enhancement
Projects
None yet
Milestone
PacketFence-7.4
Development

Successfully merging this pull request may close these issues.
3 participants
@fdurand @julsemaan @dwlfrth