feature/db-max-statement-time #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks good. Just before the merge, we'll give it a test in the admin with a low timeout and then its ready for merging |
|
Should this be a configurable value? |
|
Don't really think so, it could lead a user to set this to a value that would kill his server. That would be a case of "we know better than the user" IMO |
|
Anything need on this one? |
|
Nope, good enough, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set a timeout for database queries for the admin
Impacts
The Admin Portal and database connections
Issue
fixes #2630
Delete branch after merge
NO
NEWS file entries
Enhancements