-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add logger config to pfdns.conf #3638
Conversation
Hi! Does this change the actual output of pfdns logs in the file? We have a script that relies on how the serve dns logs are written today, is it possible that this patch is going to brake it? |
Yes it will but to have the same output as before you will need to set the log level to DEBUG. |
Hi, I've just recently updated PacketFence to v8.2 and set pfdns.conf log level to DEBUG. After configreload hard and restarting pfdns service I see on pfdns.log:
But I can only see these types of logs:
Logs like Returned portal or serve dns are not being registered. |
This is the complete output of the pfdns.log initialization:
|
Seems the rsyslog filter on the programname contains isn't working so this worksaround it. In reference to #3638 (comment)
Seems the rsyslog filter on the programname contains isn't working so this worksaround it. In reference to #3638 (comment)
@LordeRamen I've pushed a fix for that, it seems that the rsyslog rule on the programname only worked with equals so I made a patch so pfdns initializes the logging framework with the right process name (defaults to the binary path) Tomorrow, the new binary will be in the maintenance along with the updated rsyslog configuration, apply the following instructions:
|
Hi, it's working now. I noticed that pfdns.log moved to a .gz file at an unusual time (it used to be around 3 A.M., now it just did it at 9:22 A.M.), and also there are some logs from day 09 at day 12 file. What are the new rules that controls this? |
This is the logrotate configuration in /etc/logrotate.d/ but I don't believe this change should have done anything to the time its being invoked |
Description
Allows to configure pfdns logging by using our standard golang logging library
Impacts
pfdns logging
Issue
fixes #3635
Delete branch after merge
YES
NEWS file entries
Enhancements