Remove the need to create a pf::SwitchFactory object to create pf::Switch objects

[jrouzierinverse]

Description

Since the pf::SwitchFactory->instantiate method does not use any state. It
was just extra overhead to have to create a pf::SwitchFactory object to
instantiate switch objects.
Calling pf::SwitchFactory->instantiate removes the overhead of creating a pf::SwitchFactory object

Impacts

Any module that uses the pf::SwitchFactory

NEWS file entries

Enhancements
++++++++++++

• Optimize the create of switch object

Delete branch after merge

NO

[jrouzierinverse]

Please review

[julsemaan]

Looks good to me.
Has this been tested ?

[jrouzierinverse]

It passed the smoke.t

[jrouzierinverse]

Well before it was broken

[julsemaan]

I'm more talking about basic testing like instanciating a switch, making sure all services start,...

[jrouzierinverse]

Yes those test have been done.

[jrouzierinverse]

t/SwitchFactory.t
t/SNMP.t
t/floatingdevice.t
t/network-devices/cisco.t
t/network-devices/threecom.t
t/services.t
t/vlan.t