Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ipset #41

Closed
wants to merge 21 commits into from
Closed

Feature/ipset #41

wants to merge 21 commits into from

Conversation

fdurand
Copy link
Member

@fdurand fdurand commented Aug 6, 2012

for review

New Features
* Adding ipset support for inline mode
* Adding support for multivlan in inline mode
* Adding support of portal profil by vlan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/profil/profiles

@obilodeau
Copy link
Contributor

Does this fixes #1424 for all supported platforms? http://packetfence.org/bugs/view.php?id=1424

@@ -16,6 +16,8 @@ Depends: ${misc:Depends}, apache2, apache2.2-common, apache2-utils,
openssl, openssl-blacklist, openssl-blacklist-extra, php-log, snort,
mysql-server, libapache2-mod-proxy-html, libapache2-mod-php5, php-pear,
php5-mysql, php5-gd, perl-suid, make,
# ipset (ipset must be installed by hand apt-get install xtables-addons-common xtables-addons-source)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

installed by hand? reason?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must have to compil the kernel module by module-assistant auto-install xtables-addons.
So when you install packetfence with apt-get you can´t build the module in the init script (it use dpkg that is already locked).
So i prefer to document that and install by hand.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and how will that be handled in the liveusb creation process?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kernel module must be build the first time the live usb is running.
And i have a problem with installing xtables-addons-common xtables-addons-source during the build, it remove packetfence.
So by hand.

@fdurand
Copy link
Member Author

fdurand commented Aug 28, 2012

Debian , centos 6 and RHEL6, not centos 5

@obilodeau
Copy link
Contributor

re: not on centos 5

Then one of the alternatives we discussed back in june will have to be considered. Unless we are willing to drop support for it in our next feature release. Also, I'm not sure if I buy the sudoers idea. I opposed to it earlier but you still took that direction...

@fdurand
Copy link
Member Author

fdurand commented Aug 28, 2012

It´s also be possible to implement ipset on centos 5, but we have to make kernel module for at least some of the last kernel version.
For sudoers ,i was inspired by perl Captive::Portal that i think is the better solution

@fdurand
Copy link
Member Author

fdurand commented Sep 5, 2012

Warning on restart:
http://www.packetfence.org/bugs/view.php?id=1539

@dwlfrth
Copy link
Contributor

dwlfrth commented Sep 18, 2012

Do we need to keep this one opened since the whole thing have been rewritten object style?

@fdurand
Copy link
Member Author

fdurand commented Sep 18, 2012

no, but keep this branch on github yes, it has been deployed in some clients network

@dwlfrth
Copy link
Contributor

dwlfrth commented Sep 18, 2012

Closed since this has been reworked on an object oriented base
#59

@dwlfrth dwlfrth closed this Sep 18, 2012
stegar123 pushed a commit to stegar123/packetfence that referenced this pull request Jan 17, 2024
Allow fingerbank to be installed without packetfence on Debian
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants