fix/5075

[jrouzierinverse]

Description

Node deletion in consistent between the the API and pf::node::node_delete

Impacts

API

NEWS file entries

Enhancements

• Node deletion in consistent between the the API and pf::node::node_delete

Issue

fixes #5075

Delete branch after merge

NO

Checklist

• Document the feature
• Add unit tests
• Add acceptance tests (TestLink)

[nqb]

@jrouzierinverse,

Another thing I noticed. Now when you remove a node using pfcmd, you got two lines in logs:

Feb  3 09:50:06 pfcen7stable packetfence: WARN pfcmd.pl(29687): 11:11:11:11:11:11 has an open locationlog entry. Node deletion prohibited (pf::node::node_delete)
Feb  3 09:50:06 pfcen7stable packetfence: ERROR pfcmd.pl(29687): Cannot delete node 11:11:11:11:11:11 since there are some records in locationlog table indicating that this node might still be connected and active on the network  (pf::cmd::pf::node::action_delete)

and you get "Cannot delete node 11:11:11:11:11:11 .." on STDERR.

IMO, we should adjust action_delete function in pf::cmd::pf::node to:

• use message returns by API in place of this different message
• display message returns by API on STDERR

[nqb]

@jrouzierinverse, what about my last comment ?

[nqb]

It works as expected.