fix/6088 #6095
fix/6088 #6095
Conversation
|
What about: |
|
Not really agree with this PR. We should first use something like _bouncePortCoa here https://github.com/inverse-inc/packetfence/pull/6095/files#diff-7846c679ffe675238b4ec682eb6ed4537c7de86e1dfb409781b3b9a3d0f71ceeR196 and only keep the $mac extra parameter to bouncePort. |
|
@lyubomirtraykov Those are done.
|
|
@fdurand setAdminStatus was already using radius calls for the following modules. |
| if (!$mac) { | ||
| $logger->info("Can't find MAC address in the locationlog... we won't perform port bounce"); | ||
| return $TRUE; | ||
| } | ||
|
|
||
| if ( !$self->isProductionMode() ) { |
There was a problem hiding this comment.
This check should be in the bouncePort sub, like Template module.
|
|
||
| #We need to fetch the MAC on the ifIndex in order to bounce switch port with CoA. | ||
| if (!$mac) { | ||
| my @locationlog = locationlog_view_open_switchport_no_VoIP( $self->{_ip}, $ifIndex ); |
There was a problem hiding this comment.
Is this necessary? The lookup is already done in the Node.pm
jrouzierinverse
force-pushed
the
fix/6088
branch
from
0b18646
to
091ed97
Compare
|
Will this fix be merged before 10.3 release? |
|
no |
|
Will this be merged anytime soon? |
jrouzierinverse
force-pushed
the
fix/6088
branch
from
4b359c6
to
02c06f5
Compare
jrouzierinverse
force-pushed
the
fix/6088
branch
from
02c06f5
to
fc1039e
Compare
Description
Avoid looking up a mac lookup when bouncing a port when the mac is known.
Impacts
Bouncing ports
NEWS file entries
Bug Fixes
Issue
fixes #6088
Delete branch after merge
NO
Checklist