WMI documentation removed #7649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extrafu
reviewed
May 3, 2023
| @@ -1603,9 +1603,6 @@ The option `NTLM cache background job` and its associated parameters have been d | |||
|
|
|||
| The `pf-maint.pl` script used to get maintenance patches has been deprecated. You can now get maintenance patches using your package manager, see <<#_apply_maintenance_patches,Apply maintenance patches section>>. | |||
|
|
|||
| === WMI scan engine deprecated | |||
There was a problem hiding this comment.
We should keep that in the upgrade guide - because otherwise if someone does upgrade from an old version of PF and doesn't run /usr/local/pf/addons/upgrade/to-11.1-remove-wmi-scan.pl it might break their PacketFence installation.
There was a problem hiding this comment.
it should be ok now ?
|
Looks good, let's merge and update the NEWS file. Thanks! 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(REQUIRED)
Describe what the new code is used for.
Removing WMI from the documentation
Impacts
(REQUIRED)
Describe what to reviewer should look at. Will also help for testing purposes.
N/A
Delete branch after merge
(REQUIRED)
YES
Checklist
(REQUIRED) - [yes, no or n/a]
NEWS file entries
(REQUIRED, but may be optional...)
Enhancements
WMI remove from the documentation
UPGRADE file entries
(OPTIONAL, but may be required...)
PacketFence_Upgrade_Guide
performing_compliance_checks
archived_upgrade_notes