Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IProvider Example in the README doesn't compile #169

Closed
markis opened this issue Apr 11, 2016 · 2 comments
Closed

IProvider Example in the README doesn't compile #169

markis opened this issue Apr 11, 2016 · 2 comments

Comments

@markis
Copy link

markis commented Apr 11, 2016

Expected Behavior

Copy and Paste the code in the 'Injecting a Provider (asynchronous Factory)' section of the readme should compile and run.

Current Behavior

error TS2339: Property '_katana' does not exist on type 'Ninja'.
error TS2339: Property '_shuriken' does not exist on type 'Ninja'.

Possible Solution

Update the code to something that compiles

Steps to Reproduce (for bugs)

1.) Copy the code in the 'Injecting a Provider (asynchronous Factory)' section
2.) Paste the code into another file
3.) Run tsc
4.) Error in console

Context

Just trying to learn.

Your Environment

Node.js 5.10

Stack trace

README.md

@markis
Copy link
Author

markis commented Apr 11, 2016

Hi, I like what you all are doing with this project. Just trying to help out when I find things that need addressed.

@remojansen
Copy link
Member

Thanks a lot for the PR. Your help is more than welcome we really need people like you to help us to spot issue before we do a production-ready release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants