Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IProvider Example doesnt compile #170

Merged
merged 1 commit into from
Apr 11, 2016
Merged

IProvider Example doesnt compile #170

merged 1 commit into from
Apr 11, 2016

Conversation

markis
Copy link

@markis markis commented Apr 11, 2016

Description

IProvider Example in the README doesn't compile

Related Issue

#169

Motivation and Context

So that others don't get tripped up with the same error.

How Has This Been Tested?

1.) Copy the code in the 'Injecting a Provider (asynchronous Factory)' section
2.) Paste the code into another file
3.) Run tsc
4.) Should compile and run

Types of changes

  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x ] My code follows the code style of this project.
  • [ x ] My change requires a change to the documentation.
  • [ x ] I have updated the documentation accordingly.
  • My change requires a change to the type definitions.
  • I have updated the type definitions accordingly.
  • [ x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @remojansen, @adidahiya and @PeterDaveHello to be potential reviewers

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cc7cc31 on markistaylor:iprovider-bug into 9a04e95 on inversify:master.

@markis markis closed this Apr 11, 2016
@markis markis reopened this Apr 11, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cc7cc31 on markistaylor:iprovider-bug into 9a04e95 on inversify:master.

@remojansen remojansen merged commit c95c7e0 into inversify:master Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants