Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#146: Docu for workaround for issue with reflect-metadata library. #165

Merged
merged 1 commit into from
Apr 8, 2016
Merged

#146: Docu for workaround for issue with reflect-metadata library. #165

merged 1 commit into from
Apr 8, 2016

Conversation

KarolBuchta
Copy link

Description

Added documentation.

Related Issue

#146

Motivation and Context

See Issue, documentation for reflect-metadata pulling node builtins into bundle when using browserify

How Has This Been Tested?

Suggested workaround is part of a production build.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change requires a change to the type definitions.
  • I have updated the type definitions accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @remojansen to be a potential reviewer

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f9bd9b8 on KarolBuchta:master into 98777c5 on inversify:master.

@remojansen remojansen merged commit 186b7cb into inversify:master Apr 8, 2016
@remojansen
Copy link
Member

@KarolBuchta thanks a lot for your help 👍 and congratulations for your first PR 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants