Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw exceptions when in CI and inputs are needed where user prompts are not possible. Validated bundle Ids for apple and package names for android. #276

Merged
merged 10 commits into from
Apr 12, 2024

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Apr 11, 2024

Description

  • Removed throwing exception when running on CI for certain arguments. Instead, we throw exceptions whenever there is a prompt and configuration is occurring on CI.
  • Validates app bundle id for apple apps and package names for android
  • Removed unneeded arguments in e2e tests now that it won't throw exception if it is missing.
  • Moved platform selection ahead of input validation for different platforms. Also check if user selected that platform for configuration before asking them to validate inputs for that platform.

closes #233

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

@russellwheatley russellwheatley changed the title fix: throw exceptions when in CI and inputs are needed when prompts are not possible. Validated bundle Id and package name for android. fix: throw exceptions when in CI and inputs are needed where user prompts are not possible. Validated bundle Ids for apple and package names for android. Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Invalid argument(s): Option macos-bundle-id is mandatory
2 participants