-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: throw exceptions when in CI and inputs are needed where user prompts are not possible. Validated bundle Ids for apple and package names for android. #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellwheatley
had a problem deploying
to
CI Environment
April 11, 2024 11:05
— with
GitHub Actions
Failure
russellwheatley
had a problem deploying
to
CI Environment
April 11, 2024 11:05
— with
GitHub Actions
Failure
russellwheatley
temporarily deployed
to
CI Environment
April 11, 2024 11:05
— with
GitHub Actions
Inactive
russellwheatley
changed the title
fix: throw exceptions when in CI and inputs are needed when prompts are not possible. Validated bundle Id and package name for android.
fix: throw exceptions when in CI and inputs are needed where user prompts are not possible. Validated bundle Ids for apple and package names for android.
Apr 11, 2024
russellwheatley
temporarily deployed
to
CI Environment
April 11, 2024 11:29
— with
GitHub Actions
Inactive
russellwheatley
temporarily deployed
to
CI Environment
April 11, 2024 11:29
— with
GitHub Actions
Inactive
russellwheatley
temporarily deployed
to
CI Environment
April 11, 2024 11:29
— with
GitHub Actions
Inactive
russellwheatley
temporarily deployed
to
CI Environment
April 11, 2024 12:11
— with
GitHub Actions
Inactive
russellwheatley
had a problem deploying
to
CI Environment
April 11, 2024 12:11
— with
GitHub Actions
Failure
russellwheatley
temporarily deployed
to
CI Environment
April 11, 2024 12:11
— with
GitHub Actions
Inactive
7 tasks
russellwheatley
temporarily deployed
to
CI Environment
April 11, 2024 12:31
— with
GitHub Actions
Inactive
russellwheatley
temporarily deployed
to
CI Environment
April 11, 2024 12:31
— with
GitHub Actions
Inactive
russellwheatley
temporarily deployed
to
CI Environment
April 11, 2024 12:31
— with
GitHub Actions
Inactive
Lyokone
approved these changes
Apr 11, 2024
This was referenced Apr 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #233
Type of Change
feat
-- New feature (non-breaking change which adds functionality)fix
-- Bug fix (non-breaking change which fixes an issue)!
-- Breaking change (fix or feature that would cause existing functionality to change)refactor
-- Code refactorci
-- Build configuration changedocs
-- Documentationchore
-- Chore