chore: code comment for cancelling fcm notifications on android #176
Conversation
…emove unsued method `cancelNotification` in `NotificationManager.java`
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
=========================================
Coverage ? 78.62%
=========================================
Files ? 29
Lines ? 1529
Branches ? 496
=========================================
Hits ? 1202
Misses ? 327
Partials ? 0 |
| @@ -410,31 +410,6 @@ | |||
| .continueWith(CACHED_THREAD_POOL, fullScreenActionContinuation); | |||
| } | |||
|
|
|||
| static Task<Void> cancelNotification( | |||
There was a problem hiding this comment.
Guessing so based on updated description 😀 so ignore me haha, just curious why this API was removed
There was a problem hiding this comment.
yea 😅 I just noticed it wasn't removed. it snuck in again somehow 🙈
Edit: deeper explanation: it basically was to make it easier to maintain all the cancel methods that accepted id(s) on android e.g. cancelAllNotifications([ids]) and cancelNotification(id) (https://github.com/invertase/notifee/pull/119/files) so there's one common method on android cancelAllNotificationsWithIds. Eventually, we'd want iOS to behave the same way - I'll create a ticket to ensure it's not forgotten.
helenaford
deleted the
helenaford/add-code-comment-for-cancelling-fcm-notifications-on-android
branch
Add more details why we parse 0 as an integer when cancelling a notification with id of "0" and remove unused method
cancelNotificationinNotificationManager.java