feat!: all packages should depend on core (#3613)

All packages now peer-depend on an explicit version of the `app` package.

BREAKING CHANGE: breaking change to mark new internal versioning requirements.

packages/admob/RNFBAdMob.podspec

@@ -1,7 +1,17 @@
 require 'json'
 package = JSON.parse(File.read(File.join(__dir__, 'package.json')))
-
-firebase_sdk_version = '~> 6.13.0'
+appPackage = JSON.parse(File.read(File.join('..', 'app', 'package.json')))
+
+coreVersionDetected = appPackage['version']
+coreVersionRequired = package['peerDependencies'][appPackage['name']]
+if appPackage['sdkVersions']
+  firebase_sdk_version = appPackage['sdkVersions']['ios']['firebase']
+else
+  firebase_sdk_version = '~> 6.13.0'
+end
+if coreVersionDetected != coreVersionRequired
+  Pod::UI.warn "NPM package '#{package['name']}' depends on '#{appPackage['name']}' v#{coreVersionRequired} but found v#{coreVersionDetected}, this might cause build issues or runtime crashes."
+end
 
 Pod::Spec.new do |s|
   s.name                = "RNFBAdMob"

packages/admob/android/build.gradle

@@ -1,3 +1,5 @@
+import io.invertase.gradle.common.PackageJson
+
 buildscript {
   // The Android Gradle plugin is only required when opening the android folder stand-alone.
   // This avoids unnecessary downloads and potential conflicts when the library is included as a
@@ -18,10 +20,30 @@ plugins {
   id "io.invertase.gradle.build" version "1.4"
 }
 
+def appProject
+if (findProject(':@react-native-firebase_app')) {
+  appProject = project(':@react-native-firebase_app')
+} else if (findProject(':react-native-firebase_app')) {
+  appProject = project(':react-native-firebase_app')
+} else {
+  throw new GradleException('Could not find the react-native-firebase/app package, have you installed it?')
+}
+def packageJson = PackageJson.getForProject(project)
+def appPackageJson = PackageJson.getForProject(appProject)
+def firebaseBomVersion = appPackageJson['sdkVersions'] ? appPackageJson['sdkVersions']['android']['firebase'] : "24.1.0"
+def coreVersionDetected = appPackageJson['version']
+def coreVersionRequired = packageJson['peerDependencies'][appPackageJson['name']]
+// Only log after build completed so log warning appears at the end
+if (coreVersionDetected != coreVersionRequired) {
+  gradle.buildFinished {
+    project.logger.warn("ReactNativeFirebase WARNING: NPM package '${packageJson['name']}' depends on '${appPackageJson['name']}' v${coreVersionRequired} but found v${coreVersionDetected}, this might cause build issues or runtime crashes.")
+  }
+}
+
 project.ext {
   set('react-native', [
     versions: [
-      android           : [
+      android : [
         minSdk    : 16,
         targetSdk : 28,
         compileSdk: 28,
@@ -30,11 +52,11 @@ project.ext {
         buildTools: "28.0.3"
       ],
 
-      firebase          : [
-        bom: "24.1.0"
+      firebase: [
+        bom: firebaseBomVersion
       ],
 
-      ads          : [
+      ads     : [
         consent: "1.0.6"
       ],
     ],
@@ -59,7 +81,7 @@ android {
   defaultConfig {
     multiDexEnabled true
     manifestPlaceholders = [
-      firebaseJSONAdmobAppID: firebaseJSONAdmobAppIDString,
+      firebaseJSONAdmobAppID                  : firebaseJSONAdmobAppIDString,
       firebaseJSONAdmobDelayAppMeasurementInit: firebaseJSONAdmobDelayAppMeasurementInitBool
     ]
   }
@@ -79,13 +101,7 @@ repositories {
 }
 
 dependencies {
-  if (findProject(':@react-native-firebase_app')) {
-    api project(':@react-native-firebase_app')
-  } else if (findProject(':react-native-firebase_app')) {
-    api project(':react-native-firebase_app')
-  } else {
-    throw new GradleException('Could not find the react-native-firebase/app package, have you installed it?')
-  }
+  api appProject
   implementation platform("com.google.firebase:firebase-bom:${ReactNative.ext.getVersion("firebase", "bom")}")
   implementation "com.google.firebase:firebase-ads"
   implementation "com.google.android.ads.consent:consent-library:${ReactNative.ext.getVersion("ads", "consent")}"

packages/admob/package.json

@@ -27,7 +27,7 @@
     "ad consent"
   ],
   "peerDependencies": {
-    "@react-native-firebase/app": "*"
+    "@react-native-firebase/app": "6.7.1"
   },
   "publishConfig": {
     "access": "public"

packages/analytics/RNFBAnalytics.podspec

@@ -1,7 +1,17 @@
 require 'json'
 package = JSON.parse(File.read(File.join(__dir__, 'package.json')))
+appPackage = JSON.parse(File.read(File.join('..', 'app', 'package.json')))
 
-firebase_sdk_version = '~> 6.13.0'
+coreVersionDetected = appPackage['version']
+coreVersionRequired = package['peerDependencies'][appPackage['name']]
+if appPackage['sdkVersions']
+  firebase_sdk_version = appPackage['sdkVersions']['ios']['firebase']
+else
+  firebase_sdk_version = '~> 6.13.0'
+end
+if coreVersionDetected != coreVersionRequired
+  Pod::UI.warn "NPM package '#{package['name']}' depends on '#{appPackage['name']}' v#{coreVersionRequired} but found v#{coreVersionDetected}, this might cause build issues or runtime crashes."
+end
 
 Pod::Spec.new do |s|
   s.name                = "RNFBAnalytics"

packages/analytics/android/build.gradle

@@ -1,3 +1,5 @@
+import io.invertase.gradle.common.PackageJson
+
 buildscript {
   // The Android Gradle plugin is only required when opening the android folder stand-alone.
   // This avoids unnecessary downloads and potential conflicts when the library is included as a
@@ -18,6 +20,27 @@ plugins {
   id "io.invertase.gradle.build" version "1.4"
 }
 
+def appProject
+if (findProject(':@react-native-firebase_app')) {
+  appProject = project(':@react-native-firebase_app')
+} else if (findProject(':react-native-firebase_app')) {
+  appProject = project(':react-native-firebase_app')
+} else {
+  throw new GradleException('Could not find the react-native-firebase/app package, have you installed it?')
+}
+def packageJson = PackageJson.getForProject(project)
+def appPackageJson = PackageJson.getForProject(appProject)
+def firebaseBomVersion = appPackageJson['sdkVersions'] ? appPackageJson['sdkVersions']['android']['firebase'] : "24.1.0"
+def coreVersionDetected = appPackageJson['version']
+def coreVersionRequired = packageJson['peerDependencies'][appPackageJson['name']]
+// Only log after build completed so log warning appears at the end
+if (coreVersionDetected != coreVersionRequired) {
+  gradle.buildFinished {
+    project.logger.warn("ReactNativeFirebase WARNING: NPM package '${packageJson['name']}' depends on '${appPackageJson['name']}' v${coreVersionRequired} but found v${coreVersionDetected}, this might cause build issues or runtime crashes.")
+  }
+}
+
+
 project.ext {
   set('react-native', [
     versions: [
@@ -31,7 +54,7 @@ project.ext {
       ],
 
       firebase          : [
-        bom: "24.1.0",
+        bom: firebaseBomVersion,
       ],
     ],
   ])
@@ -62,13 +85,7 @@ repositories {
 }
 
 dependencies {
-  if (findProject(':@react-native-firebase_app')) {
-    api project(':@react-native-firebase_app')
-  } else if (findProject(':react-native-firebase_app')) {
-    api project(':react-native-firebase_app')
-  } else {
-    throw new GradleException('Could not find the react-native-firebase/app package, have you installed it?')
-  }
+  api appProject
   implementation platform("com.google.firebase:firebase-bom:${ReactNative.ext.getVersion("firebase", "bom")}")
   implementation "com.google.firebase:firebase-analytics"
 }

packages/analytics/package.json

@@ -22,7 +22,7 @@
     "analytics"
   ],
   "peerDependencies": {
-    "@react-native-firebase/app": "*"
+    "@react-native-firebase/app": "6.7.1"
   },
   "publishConfig": {
     "access": "public"

packages/app/RNFBApp.podspec

@@ -1,8 +1,7 @@
 require 'json'
 require './firebase_json'
 package = JSON.parse(File.read(File.join(__dir__, 'package.json')))
-
-firebase_sdk_version = '~> 6.13.0'
+firebase_sdk_version = package['sdkVersions']['ios']['firebase'] || '~> 6.13.0'
 
 Pod::Spec.new do |s|
   s.name                = "RNFBApp"

packages/app/android/build.gradle

@@ -1,3 +1,5 @@
+import io.invertase.gradle.common.PackageJson
+
 buildscript {
   // The Android Gradle plugin is only required when opening the android folder stand-alone.
   // This avoids unnecessary downloads and potential conflicts when the library is included as a
@@ -18,6 +20,9 @@ plugins {
   id "io.invertase.gradle.build" version "1.4"
 }
 
+def packageJson = PackageJson.getForProject(project)
+def firebaseBomVersion = packageJson['sdkVersions']['android']['firebase']
+
 project.ext {
   set('react-native', [
     versions: [
@@ -31,7 +36,7 @@ project.ext {
       ],
 
       firebase: [
-        bom: "24.1.0",
+        bom: firebaseBomVersion,
       ],
     ],
   ])

packages/app/package.json

@@ -63,5 +63,13 @@
   },
   "publishConfig": {
     "access": "public"
+  },
+  "sdkVersions": {
+    "ios" : {
+      "firebase": "~> 6.13.0"
+    },
+    "android": {
+      "firebase": "24.1.0"
+    }
   }
 }

packages/auth/RNFBAuth.podspec

@@ -1,7 +1,17 @@
 require 'json'
 package = JSON.parse(File.read(File.join(__dir__, 'package.json')))
+appPackage = JSON.parse(File.read(File.join('..', 'app', 'package.json')))
 
-firebase_sdk_version = '~> 6.13.0'
+coreVersionDetected = appPackage['version']
+coreVersionRequired = package['peerDependencies'][appPackage['name']]
+if appPackage['sdkVersions']
+  firebase_sdk_version = appPackage['sdkVersions']['ios']['firebase']
+else
+  firebase_sdk_version = '~> 6.13.0'
+end
+if coreVersionDetected != coreVersionRequired
+  Pod::UI.warn "NPM package '#{package['name']}' depends on '#{appPackage['name']}' v#{coreVersionRequired} but found v#{coreVersionDetected}, this might cause build issues or runtime crashes."
+end
 
 Pod::Spec.new do |s|
   s.name                = "RNFBAuth"

packages/auth/android/build.gradle

@@ -1,3 +1,5 @@
+import io.invertase.gradle.common.PackageJson
+
 buildscript {
   // The Android Gradle plugin is only required when opening the android folder stand-alone.
   // This avoids unnecessary downloads and potential conflicts when the library is included as a
@@ -18,6 +20,27 @@ plugins {
   id "io.invertase.gradle.build" version "1.4"
 }
 
+def appProject
+if (findProject(':@react-native-firebase_app')) {
+  appProject = project(':@react-native-firebase_app')
+} else if (findProject(':react-native-firebase_app')) {
+  appProject = project(':react-native-firebase_app')
+} else {
+  throw new GradleException('Could not find the react-native-firebase/app package, have you installed it?')
+}
+def packageJson = PackageJson.getForProject(project)
+def appPackageJson = PackageJson.getForProject(appProject)
+def firebaseBomVersion = appPackageJson['sdkVersions'] ? appPackageJson['sdkVersions']['android']['firebase'] : "24.1.0"
+def coreVersionDetected = appPackageJson['version']
+def coreVersionRequired = packageJson['peerDependencies'][appPackageJson['name']]
+// Only log after build completed so log warning appears at the end
+if (coreVersionDetected != coreVersionRequired) {
+  gradle.buildFinished {
+    project.logger.warn("ReactNativeFirebase WARNING: NPM package '${packageJson['name']}' depends on '${appPackageJson['name']}' v${coreVersionRequired} but found v${coreVersionDetected}, this might cause build issues or runtime crashes.")
+  }
+}
+
+
 project.ext {
   set('react-native', [
     versions: [
@@ -30,7 +53,7 @@ project.ext {
         buildTools: "28.0.3"
       ],
       firebase          : [
-        bom : "24.1.0",
+        bom : firebaseBomVersion,
       ],
     ],
   ])
@@ -56,13 +79,7 @@ repositories {
 }
 
 dependencies {
-  if (findProject(':@react-native-firebase_app')) {
-    api project(':@react-native-firebase_app')
-  } else if (findProject(':react-native-firebase_app')) {
-    api project(':react-native-firebase_app')
-  } else {
-    throw new GradleException('Could not find the react-native-firebase/app package, have you installed it?')
-  }
+  api appProject
   implementation platform("com.google.firebase:firebase-bom:${ReactNative.ext.getVersion("firebase", "bom")}")
   implementation "com.google.firebase:firebase-auth"
 }

packages/auth/package.json

@@ -22,7 +22,7 @@
     "auth"
   ],
   "peerDependencies": {
-    "@react-native-firebase/app": "*"
+    "@react-native-firebase/app": "6.7.1"
   },
   "publishConfig": {
     "access": "public"

packages/crashlytics/RNFBCrashlytics.podspec

@@ -1,8 +1,18 @@
 require 'json'
 package = JSON.parse(File.read(File.join(__dir__, 'package.json')))
+appPackage = JSON.parse(File.read(File.join('..', 'app', 'package.json')))
 
 # Firebase SDK Override
-firebase_sdk_version = '~> 6.13.0'
+coreVersionDetected = appPackage['version']
+coreVersionRequired = package['peerDependencies'][appPackage['name']]
+if appPackage['sdkVersions']
+  firebase_sdk_version = appPackage['sdkVersions']['ios']['firebase']
+else
+  firebase_sdk_version = '~> 6.13.0'
+end
+if coreVersionDetected != coreVersionRequired
+  Pod::UI.warn "NPM package '#{package['name']}' depends on '#{appPackage['name']}' v#{coreVersionRequired} but found v#{coreVersionDetected}, this might cause build issues or runtime crashes."
+end
 
 # Fabric SDK Override
 fabric_sdk_version = '~> 1.10.2'

packages/crashlytics/android/build.gradle

@@ -1,3 +1,5 @@
+import io.invertase.gradle.common.PackageJson
+
 buildscript {
   // The Android Gradle plugin is only required when opening the android folder stand-alone.
   // This avoids unnecessary downloads and potential conflicts when the library is included as a
@@ -18,6 +20,27 @@ plugins {
   id "io.invertase.gradle.build" version "1.4"
 }
 
+def appProject
+if (findProject(':@react-native-firebase_app')) {
+  appProject = project(':@react-native-firebase_app')
+} else if (findProject(':react-native-firebase_app')) {
+  appProject = project(':react-native-firebase_app')
+} else {
+  throw new GradleException('Could not find the react-native-firebase/app package, have you installed it?')
+}
+def packageJson = PackageJson.getForProject(project)
+def appPackageJson = PackageJson.getForProject(appProject)
+def firebaseBomVersion = appPackageJson['sdkVersions'] ? appPackageJson['sdkVersions']['android']['firebase'] : "24.1.0"
+def coreVersionDetected = appPackageJson['version']
+def coreVersionRequired = packageJson['peerDependencies'][appPackageJson['name']]
+// Only log after build completed so log warning appears at the end
+if (coreVersionDetected != coreVersionRequired) {
+  gradle.buildFinished {
+    project.logger.warn("ReactNativeFirebase WARNING: NPM package '${packageJson['name']}' depends on '${appPackageJson['name']}' v${coreVersionRequired} but found v${coreVersionDetected}, this might cause build issues or runtime crashes.")
+  }
+}
+
+
 project.ext {
   set('react-native', [
     versions: [
@@ -58,13 +81,7 @@ repositories {
 }
 
 dependencies {
-  if (findProject(':@react-native-firebase_app')) {
-    api project(':@react-native-firebase_app')
-  } else if (findProject(':react-native-firebase_app')) {
-    api project(':react-native-firebase_app')
-  } else {
-    throw new GradleException('Could not find the react-native-firebase/app package, have you installed it?')
-  }
+  api appProject
   // don't use firebase bom here as crashlytics-ndk is not included in the bom, trying to partially use bom here fails
   implementation "com.crashlytics.sdk.android:crashlytics:${ReactNative.ext.getVersion("firebase", "crashlytics")}"
   // ndk not in Firebase BoM